GithubHelp home page GithubHelp logo

Hooks errors fix for #687 about chimpy HOT 5 OPEN

samhatoum avatar samhatoum commented on July 24, 2024
Hooks errors fix for #687

from chimpy.

Comments (5)

samhatoum avatar samhatoum commented on July 24, 2024

Comment by rsshilli
Tuesday Jun 05, 2018 at 19:07 GMT


Huh. The tests on Firefox failed because "Error: Failed to decode response from marionette". I have no idea why that would happen (or what it means, honestly). Was that something I caused?

I'd retry the build but I don't have permission.

from chimpy.

samhatoum avatar samhatoum commented on July 24, 2024

Comment by rsshilli
Tuesday Jun 05, 2018 at 19:09 GMT


These tests for Firefox passed when i ran them locally on my Ubuntu Windows Subsystem.

from chimpy.

samhatoum avatar samhatoum commented on July 24, 2024

Comment by rsshilli
Thursday Jun 07, 2018 at 18:09 GMT


@samhatoum I think I need your help here. Can you give me any advice?

from chimpy.

rsshilli avatar rsshilli commented on July 24, 2024

This fix for src/lib/cucumberjs/hooks.js is still needed:

QbDVision-Inc@b48a2a5#diff-749adcafde5c87c756c5ed23d1de29dd

In bad situations, the test will fail but the build system will think that it passed because you're not exiting with a non-zero exit code. This causes false-positive test results which is really, really bad!

from chimpy.

lgandecki avatar lgandecki commented on July 24, 2024

@dweller23 could you please apply that change and publish a new version? Thanks!

from chimpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.