GithubHelp home page GithubHelp logo

Comments (7)

thecodrr avatar thecodrr commented on May 22, 2024 1

Will release v5.3.0 then

from fdir.

thecodrr avatar thecodrr commented on May 22, 2024 1

One small piece of unsolicited feedback, is that this might fall into the boolean trap.

I agree. I'll be making some breaking changes in v6.0 so this API is definitely not final. There's a lot of confusion in the current exposed methods so I will do some much needed renaming as well.

from fdir.

thecodrr avatar thecodrr commented on May 22, 2024

WIP at #84

from fdir.

thecodrr avatar thecodrr commented on May 22, 2024

@IanVS can you test against master branch and see if that works for you?

from fdir.

IanVS avatar IanVS commented on May 22, 2024

Yep, I copied over the src from master and it's now working correctly! Thanks!

from fdir.

thecodrr avatar thecodrr commented on May 22, 2024

@IanVS done. I changed the API a bit to be backwards compatible with v5 so check the docs to see how you can use it.

from fdir.

IanVS avatar IanVS commented on May 22, 2024

Thanks. One small piece of unsolicited feedback, is that this might fall into the boolean trap. When reading .withSymlinks(false) it could reasonably be thought that symlinks are disabled. An API like .withSymlinks({ resolve: boolean }) gives a bit more clarity, IMHO. But, that's just my own two cents. Thanks again for getting this released so quickly!

from fdir.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.