Comments (5)
@pranksinatra I just released 0.14.0 which includes a fix for your issue and tested it with the Razzle app. I'm going to close this issue but feel free to re-open it if it's not resolved.
Note: please make sure to bump the version of microstates and run build before trying it.
from microstates.
@pranksinatra Thank you for taking the time to let us know about this problem. You're absolutely right: it's one that we've seen before thefrontside/funcadelic.js#63 Although I thought we'd quashed it :)
This happened before because uglify was removing the implicit name
property that was added to constructors. Causing the following exception to be triggered. https://github.com/cowboyd/funcadelic.js/blob/a3b8aea1353329369816de697115bbda1ca23e88/src/typeclasses.js#L13-L17
We mitigated this by making every class, get its own name explicitly. Like this one here https://github.com/microstates/microstates.js/blob/master/src/tree.js#L6
I think the following would help diagnose the issue:
- microstates version
- complete stacktrace
from microstates.
The workaround when using uglify was to set the keep_classnames
option microstates/ember#98 (comment)
Perhaps there is an equivalent with Terser?
from microstates.
You can see in the built output that the class names are missing.
If Razzer used keep-classnames
flag then it would work.
I believe the change needs to be applied here https://github.com/jaredpalmer/razzle/blob/8fed32b57ec5b75c421e04f00a4081da687ab6d6/packages/razzle/config/createConfig.js#L516
We mitigated this by making every class, get its own name explicitly.
We did this in Microstates but not in Funcadelic. Should we apply the same fix to Funcadelic?
from microstates.
@pranksinatra I was able to reproduce the issue with Razzle and test a fix. Please standby for a new release.
from microstates.
Related Issues (20)
- Typescript types definition files HOT 4
- Proposal for composition Microstates Effects HOT 4
- Handling onChange for Number Type HOT 8
- Remove `parameterized` functionality and replace with simple functions
- Proposal for auto publish process HOT 5
- ArrayType#sort should pass microstates to comparer instead of value
- Quest: TypeScript support
- An in-range update of mocha is breaking the build 🚨 HOT 8
- An in-range update of rollup is breaking the build 🚨 HOT 81
- Control child Microstate creation HOT 13
- Export `query()` function
- Add `flatMap` method to query.
- add `concat` method to query
- General usage feedback (naming things, type checks) HOT 4
- Publishing to NPM with branch as tag HOT 4
- from() examples with objects don't work HOT 5
- Is this library stable? HOT 2
- Update logo for social preview HOT 2
- Can microstates be used in the browser? (IE11)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from microstates.