Extension stealing keyboard focus about gnome-shell-extension-transmission-daemon

[TheKevJames]

Note that v27 introduced a fairly significant re-write in order to support gnome-shell v3.34 -- this issue may no longer occur.

[p2004a]

This is still happening. I have Gnome 3.34.3 and this extension at version v27. It's present both on wayland and X11.

I've tried to debug this a bit, I've figured that this happens when "Always show the indicator" is false and transmission isn't running (PanelMenu is not visible).

I've tracked down that changing TransmissionDaemonIndicatorClass.hide to (add this.visible check):

if (!this._always_show && this.visible) {
    this.visible = false;
}

fixes the bug.

I've also noticed that it's not the only bug related to focus. In the not connected state the operation "click transmission indicator to show menu, click to hide it" toggles the focus of window:

1. Window A has focus.
2. Click indicator, menu shows up
3. Click indicator, menu hides and windows A loses focus (under X, focus has window with id 0, checked with xprop -root _NET_ACTIVE_WINDOW)
4. Click indicator, menu shows up
5. Click indicator, menu shows hides and windows A (not any random window) regains focus.

This doesn't happen with any other extensions that use PanelMenu eg. OpenWeather.

Now, I have not clue about developing Gnome extensions, thus I don't know how the proper fix looks like. Above snippet looks more like a workaround to me, but I hope that this description is helpful 😉.

[TheKevJames]

@p2004a this bug has been a nightmare-and-a-half to track down, so thank you for all your efforts! I've just submitted v28 to extensions.gnome with your suggested fix -- even if it doesn't fix the problem entirely, hopefully it improves things a bit!

Thanks for the additional debugging info as well -- that gives me a good direction to focus efforts, at least. I'll dig into the OpenWeather codebase and see if that sparks any joy ideas. If you find anything else, I'd love to hear about it!

I don't know what it is about this bug, but I've just never been able to replicate it no matter what I try. I'm sure its something simple I'm missing, but isn't that always the case...

[rastersoft]

It seems that this bug has re-appeared in Gnome Shell 3.36: If I play a video (I tested it with MPV and VLC), while in window mode everything works fine, but if I double click or press F to change to full screen mode, the window losses the focus and I must do a click to be able to continue to manage it with the keyboard.

(but I don't remember problems with Gnome Shell 3.34 or previous)

[rastersoft]

I found how to fix it. I uploaded a patch.

[TheKevJames]

I've pushed release v29 with @rastersoft's fix (thanks again!). Hopefully this is the last of it (crossed fingers).

[TheKevJames]

We've not received a report of this in two months -- closing this as resolved. Thanks again for contributing the various fixes here, folks!