Comments (8)
You are very right 👍
from ticketit.
Hardcoded CSS is building fast we need to agree on some naming conventions for TicketIT id and class tags and follow the pattern throughout, also need a custom stylesheet implemented.
from ticketit.
I don't know if most email clients support stylesheets. Every Open Source template I've ever seen has inline styles with comments like "" and stuff.
This was an open source template as well that I converted into a theme.
from ticketit.
Which is why database setting variable in a ticketit_email_templates database may be wise
from ticketit.
Then we can have multiple "themes" that use the same template
from ticketit.
That said, I totally agree on id's and classes throughout the normal app.
from ticketit.
Agree, emails should have embedded styles - linked stylesheets in emails break to often and probably end up in clients spam folders.
Are we going to just wing-it with class names or follow the existing TitcketIT folder structure?
should we wrap each View file within its own custom div and ID or do integrate into existing the bootstrap something like below:
vendor\kordy\ticketit\src\Views\tickets\index.blade.php
Before: <div class="panel panel-default"> // Line 1 in view file
After: <div id="ticketit" class="panel panel-default ticketit-index" >
vendor\kordy\ticketit\src\Views\tickets\create.blade.php
Before: <div class="well bs-component"> // Line 1 in view file
After: <div id="ticketit" class="well bs-component ticketit-create">
vendor\kordy\ticketit\src\Views\tickets\show.blade.php (\partials\ticketit_body.blade.php)
Before: <div class="panel panel-default"> // Line 1 in view file
After: <div id="ticketit" class="panel panel-default ticketit-show ticket-{{ $ticket->id }}" >
OR assign ID once in Master, then use classes only in views
vendor\kordy\ticketit\src\Views\index.blade.php
@section('content')
Before: <div class="row">
After: <div class="row" id="ticketit">
vendor\kordy\ticketit\src\Views\tickets\index.blade.php
Before: <div class="panel panel-default"> // Line 1 in view file
After: <div class="panel panel-default ticketit-index" >
vendor\kordy\ticketit\src\Views\tickets\create.blade.php
Before: <div class="well bs-component"> // Line 1 in view file
After: <div class="well bs-component ticketit-create">
vendor\kordy\ticketit\src\Views\tickets\show.blade.php (\partials\ticketit_body.blade.php)
Before: <div class="panel panel-default"> // Line 1 in view file
After: <div class="panel panel-default ticketit-show ticket-{{ $ticket->id }}" >
from ticketit.
assign ID once in Master, then use classes only in views
I am with this option 👍
from ticketit.
Related Issues (20)
- Feature Request: Turn off reply-to email of agent
- Multiguard integration HOT 1
- How to localize ticketit HOT 1
- Email feature
- how to run ticket app on browser after installation , i executed php artisan ticketit:install and php artisan serve i am getting this site cant be reached on localhost:8000
- Graphics error HOT 2
- Error when install package HOT 3
- Webhook support
- kordy.info domain seems not reachable HOT 1
- composer require 'kordy/ticketit:0.*' HOT 2
- How can I enable the localization feature?
- Unable to complete Installation Process HOT 3
- Does the pacakge offer APIs? HOT 2
- Make sure that App\User exists HOT 1
- installation failed and showing below mentioned error
- Bootstrap 5
- E-Mail Function is not Working
- Use with Jetstream HOT 1
- laravel and php version
- Authenticated Remote Code Execution via Insecure Deserialization
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ticketit.