GithubHelp home page GithubHelp logo

Comments (2)

TheLovinator1 avatar TheLovinator1 commented on May 30, 2024

Hi!

Thanks for the issue, I removed the /web/ part from the URL. That seems to work on every device.

Do you want me to add the username to the URL? I can't remember why I went with https://twitter.com/i/ instead of https://twitter.com/charlieINTEL/ but I can probably add it without a problem. ¯_(ツ)_/¯

A lot of people have asked how to make the URL more visible so I modified the embed so the tweeter name is blue. One disadvantage with that is that the small avatar to the left of the name had to go, but I changed the bot so that it modifies the webhook avatar instead.
Is this better or should I revert the change? (Or make it customizable)

Should I add @CharlieIntel to the username? Right now it is only the CharlieIntel part

Is there anything else I should add or fix?

from discord-twitter-webhooks.

EthanC avatar EthanC commented on May 30, 2024

Username in the URL would be ideal. /i/status/ works because both the web and mobile clients will resolve the username regardless of what you replace i with, but it looks weird if you share that link with someone since that's not the normal format.

Personally, this would be the most appealing solution to the author and Tweet URL issue you've mentioned:

  • Maintains avatar in embed
  • Shows both display name and username
  • Adds link directly to user
  • Better visibility for the Tweet URL
embed.set_author(f"{displayName} (@{username})", url=f"https://twitter.com/{username}", icon_url=avatarUrl)
embed.set_title("Tweet") # Could change depending on type (Tweet, Retweet, Quote, or Reply?)
embed.set_url(f"https://twitter.com/{username}/status/{tweetId}")

from discord-twitter-webhooks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.