GithubHelp home page GithubHelp logo

Comments (7)

Juje avatar Juje commented on June 30, 2024 1

No problem I'll create a PR with pleasure since I need it for a feature 😉.

And I've been using main for a while now so no problem.

from framework.

jlambe avatar jlambe commented on June 30, 2024

Hi,
well I personally expect the form input to be empty if entered data is false with an error message displayed on screen why it is failing. Perhaps we could introduce a way to give the developer the option on how the form should behave with falsy values and call the appropriate validator method on submission.

from framework.

Juje avatar Juje commented on June 30, 2024

In some cases I indeed agree. But I'm currently building a config screen for editing a YML file and I don't want to lose the current progress... So ya making it configurable by a developer would indeed make sense.

from framework.

Juje avatar Juje commented on June 30, 2024

So should I create a PR or?

from framework.

jlambe avatar jlambe commented on June 30, 2024

@Juje I will appreciate a PR for sure but if you're willing to pass time on this feature, please make it against the main branch that contains the code for upcoming release. I'm not going to publish a newer version for 2. Or are you on a project that is using version 2 ?

from framework.

Juje avatar Juje commented on June 30, 2024

The PR has been created at #878.

from framework.

Juje avatar Juje commented on June 30, 2024

The PR has been merged so this issue can be closed 🙂.

from framework.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.