Undefined offset: 1 about laravel-langman

[themsaid]

hmm maybe that's the reason, will look at it in 30 minutes and get back to you. Thanks for your feedback, it's quite useful :)

I'm trying to make the package cover all the cases and make language files management as easy as possible, because in the current large project I'm working on managing translations became a nightmare.

[vpratfr]

For instance, if I want to add a new language (italian for instance), I would basically create a new it subfolder, then run the sync command and that folder would be populated with the new translation files.

[themsaid]

I just tested the case of having files existing in a language but not the other, running langman:missing actually creates a new file and asks you to fill the lines key by key.

Can you please share the structure of your language files? Or if possible can you do some debugging inside the MissingCommand and try to figure out where the problem is cause I can't replicate the issue here.

[themsaid]

@vpratfr, still having the same troubles running the package?

[vpratfr]

Same problem after updating.

[themsaid]

I really need to know the cause of the issue, cause I've used langman in 4 projects till now with complicated localisation structure and it seem to work. Can you please try to track the issue in Themsaid/Langman/Command/MissingCommand.php?

[vpratfr]

I'll try to, but I won't have time to do that until at least 1 or 2 weeks.

[themsaid]

No worries, I'm going to close the issue for now then. Please feel free to open a ticket if the issue with more details by the time you check it out. Hopefully you catch the issue and open a PR :)

Thanks for your feedback.

[vpratfr]

Pretty strange way to proceed to close an issue which is still happening?!

[themsaid]

It's just that we're unable to re-create the issue on different installation and you won't be able to provide further details so I thought to close it until somebody else reports. Anyway it's no opened again :)

[vpratfr]

Here is some more info about the Exception:

$ php artisan langman:sync -v
Reading translation keys from views...


  [ErrorException]
  Undefined offset: 1


Exception trace:
 () at vendor\themsaid\laravel-langman\src\Manager.php:64
 Illuminate\Foundation\Bootstrap\HandleExceptions->handleError() at vendor\themsaid\laravel-langman\src\Manager.php:64
 Themsaid\Langman\Manager->Themsaid\Langman\{closure}() at vendor\laravel\framework\src\Illuminate\Support\Collection.php:347
 Illuminate\Support\Collection->groupBy() at vendor\themsaid\laravel-langman\src\Manager.php:68
 Themsaid\Langman\Manager->files() at vendor\themsaid\laravel-langman\src\Commands\SyncCommand.php:53
 Themsaid\Langman\Commands\SyncCommand->handle() at n/a:n/a
 ...

[vpratfr]

This happens for a file within vendor. At line 63 I do a var_dump($file); and here is the output:

object(Symfony\Component\Finder\SplFileInfo)#873 (4) {
  ["relativePath":"Symfony\Component\Finder\SplFileInfo":private]=>
  string(20) "vendor\log-viewer\en"
  ["relativePathname":"Symfony\Component\Finder\SplFileInfo":private]=>
  string(32) "vendor\log-viewer\en\general.php"
  ["pathName":"SplFileInfo":private]=>
  string(69) "C:\Dev\sites\ikastola\resources\lang\vendor\log-viewer\en\general.php"
  ["fileName":"SplFileInfo":private]=>
  string(11) "general.php"
}

The exception is thrown because $matches is an empty array and you are trying to return $matches[1]

Here is what general.php looks like:

<?php

return [
    'all'  => 'All',
    'date' => 'Date',
];

[vpratfr]

A fix for that regex is to remove is and replace the if statement by that:

            if (Str::contains($file->getPath(), 'vendor')) {
                $fileName = basename($file->getRealPath());
                $vendorName = basename(dirname($file->getPath()));

                return "{$vendorName}::{$fileName}";
            } else {
                return $fileName;
            }

[vpratfr]

That last code seems to work (at least it runs, returns proper vendor::filename key), I did not check the messages which were output)

[themsaid]

👍 can you open a PR for that fix?

[vpratfr]

I prefer to let you test it properly, I will not have time to do that before quite some time. I actually forced myself to spend a few minutes at least trying to find where the issue was to help you fix it.

I am running on Windows, that may be why your regex is not working.

The fix seems trivial, maybe mine is not proper as the function will return something like "log-viewer::general.php" (you may not want the .php ending in that return value)

[themsaid]

Alright no problem, I'll look into a fix and release a patch once I have a couple of minutes. Thank you :)

[vpratfr]

No problem. Sorry I can't contribute more with code, I wish my days were 48 hours long.