No port in `Host` headers versus port 80 in options about forcedomain

[mrveera]

Okay @goloroden

[hooke]

Confirming the importance of the issue as the topicstarter of abovementioned SO question

[goloroden]

Thanks for the issue and sorry for replying that late.

We will have a look at it within the next few days and provide a fix.
(Of course, we are also happy about a PR ;-))

[goloroden]

@hooke Would you mind creating a PR with the solution that you proposed on StackOverflow?

[hooke]

Of course not. How can I help with such a PR?

[goloroden]

@hooke Great :-)

Well, I think the easiest way would be that you

• fork this repo,
• add your solution from SO,
• and then send a PR so I can merge it.

Is this okay for you?

[hooke]

@goloroden - ok
I'll do this in about a week, currently have no extra time for this :(

[goloroden]

This is great news, thanks a lot :-))

(And don't hurry, I'm very glad that you'll do it :-))

[bonesoul]

any updates on this?

[goloroden]

Unfortunately no. If you want to create a PR, I'd be more than happy to merge it :-)

[mrveera]

@goloroden It's been a long time from above comments.
Would you mind If I create PR?

[goloroden]

Not at all - actually I‘d be more than happy to merge one 😊

[mrveera]

Hey @goloroden,
I think I am not clear about this Can you please explain what is the problem with this issue?

[goloroden]

What is unclear with the OP‘s explanation?

[mrveera]

When there is no port in host headers and 80 specified in options its working fine for me.
It's not creating redirection loop

[goloroden]

Maybe then this issue is not relevant any more, as it was fixed meanwhile (please note that the original issue is from 2015!).

Would you mind adding a test for this behavior to prove that it's working correctly, and submitting that test as PR?

[goloroden]

This has been fixed at some point in time between 2015 and 2018, and thanks to @veera83372 we now have a test to prove that it works 😊