Comments (7)
To add more info, the error thrown is https://docs.angularjs.org/error/$parse/isecdom i suppose that it's because i'm using in-view="imageInView($inview, $element, $index)"
attribute
from angular-inview.
Than you, I didn't notice that change in AngularJS.
It's now updated in v1.4.0 where $event
is passed instead of $element
. You can still reach the affected DOM element via $event.inViewTarget
.
from angular-inview.
Hmmm…. now i'm getting this error in angular-inview: "Error: Attempted to assign to readonly property." not sure why yet...
from angular-inview.
I believe that the error throws at: $event.inViewTarget = element[0];
code
from angular-inview.
Removing 'use strict' from the script now i get this error message:
Error: 'undefined' is not an object (evaluating '$event.inViewTarget = element[0]')
from angular-inview.
Adding `ìf(typeof($event) !== 'undefined')``before that line seems to solve the problem, but i'm not sure about the consequences. All works fine now as far as i know...
from angular-inview.
Thanks, it was a bug I introduced with v1.4 and now hopefully fixed
from angular-inview.
Related Issues (20)
- Offset values HOT 4
- Bower Version HOT 1
- $inview not recalculated after initially seen and height added. HOT 1
- intersectRect fails testcase for height 0 HOT 1
- Fix package/bower.json versions, publish to npm/bower HOT 1
- does this actually require 1.5.8 HOT 2
- Having only one element active as "in-view"
- Allow for responsive handling of in-view-options by allowing expressions
- 2.2.0 is not published to npm HOT 3
- Percent in offset not calculating correctly
- no changelog for 2.3.0 HOT 2
- no longer finds zero height divs visible HOT 2
- Throttle vs delay
- Not working for me on window scrolling HOT 3
- [3.0.0] Syntax Error HOT 8
- Support angular-inview for nested containers (Should prevent the propagation of scroll event from child to container)
- What are the breaking changes in v3.0.0? HOT 4
- 3.0.0 not working in chrome-44/googlebot
- Dispose after first call
- arrow functions not supported HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from angular-inview.