GithubHelp home page GithubHelp logo

Comments (3)

colinodell avatar colinodell commented on June 16, 2024

Babelmark3 confirms that we handle this differently than GitHub's GFM implementation:

image

Unfortunately the GFM spec doesn't anything about footnote functionality, so we'll need to decide whether/how to follow their implementation anyway, assuming it follows the other principles of the spec. More research is needed here.

from commonmark.

colinodell avatar colinodell commented on June 16, 2024

After further investigation, it seems this library is working as expected. According to our spec:

Footnotes should be separated from other blocks with blank lines

We do this because the syntax for footnotes is virtually identical to link reference definitions which cannot interrupt a paragraph. In other words, if it cannot be parsed as a valid link reference then it cannot be a footnote.

I also tested your input against cmark-gfm - the "official" implementation of GFM - which gave the same results as this library.

from commonmark.

colinodell avatar colinodell commented on June 16, 2024

Note that GitHub.com does do some additional pre- and post-processing outside of cmark-gfm to support certain features on their site. This special processing is not documented in the official GFM specification. That's why we have our own spec for footnotes which tries to stay close to GitHub.com's behavior without violating the actual, official specifications.

from commonmark.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.