Missing `auto_approve` parameter about oauth2-server

[JesseFarebro]

The 'auto_approve' is a field in your database in the table oauth_clients I
believe so just set that to the desired value. The ClientIntetface doesn't
provide any way of changing this value it should be set when the client is
first made.
On May 12, 2013 6:32 AM, "Alex Bouma" [email protected] wrote:

I started implementing the OAuth2 server by your tutorial (
https://github.com/php-loep/oauth2-server/wiki/Developing-an-OAuth-2.0-authorization-server)
and found out that something is not right (or I need glasses).

The problem can be found here
https://github.com/php-loep/oauth2-server/wiki/Developing-an-OAuth-2.0-authorization-server#create-an-oauth-controllerwhen you need to create the
authorise endpoint. There is spoken of a auto_approve parameter in
client_details however it is nowhere to be found!

I checked the ClientInterface who is (that I believe) responsible for
providing that data. I looked at the docs at
https://github.com/php-loep/oauth2-server/blob/master/src/League/OAuth2/Server/Storage/ClientInterface.php#L38but there is also not spoken of an
auto_approve.

I hope this is a valid problem and not me having a bad day =]

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/55
.

[stayallive]

I know that. But I do not wish to change it but retrieve at as in the tutorial!

[JesseFarebro]

If your following that tutorial you should see its retrieved from the
associative array called params. When the request is first made
$params['client_details'] is populated with the information. So to access
it you would therefore use $params['client_details']['auto_approve']. Sorry
for the lack of formating I'm on my phone.
On May 12, 2013 3:46 PM, "Alex Bouma" [email protected] wrote:

I know that. But I do not wish to change it but retrieve at as in the
tutorial!

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/55#issuecomment-17785984
.

[stayallive]

Yeah I have seen that too :) and I also var_dumped that array... No
auto_approve to be found! So I went digging and found out that the
ClientInterface is responsible for getting that info except it doesn't!? Or
should that come from somewhere else. TL;DR The auto_approve is not set on
the $params['client_details']

NP I can read it fine without fancy formatting :)

Op 12 mei 2013 om 23:52 heeft Jesse Farebrother [email protected]
het volgende geschreven:

If your following that tutorial you should see its retrieved from the
associative array called params. When the request is first made
$params['client_details'] is populated with the information. So to access
it you would therefore use $params['client_details']['auto_approve']. Sorry
for the lack of formating I'm on my phone.
On May 12, 2013 3:46 PM, "Alex Bouma" [email protected] wrote:

I know that. But I do not wish to change it but retrieve at as in the
tutorial!

—
Reply to this email directly or view it on GitHub<
https://github.com/php-loep/oauth2-server/issues/55#issuecomment-17785984>
.

—
Reply to this email directly or view it on
GitHubhttps://github.com//issues/55#issuecomment-17786079
.

[JesseFarebro]

Well client interface just provides a interface for the storage model. Have
you tried looking to see what the default Client storage model does. It can
be located in /Leage/OAuth2/Server/Storage/PDO/Client.php I believe.
On May 12, 2013 3:57 PM, "Alex Bouma" [email protected] wrote:

Yeah I have seen that too :) and I also var_dumped that array... No
auto_approve to be found! So I went digging and found out that the
ClientInterface is responsible for getting that info except it doesn't!?
Or
should that come from somewhere else. TL;DR The auto_approve is not set on
the $params['client_details']

NP I can read it fine without fancy formatting :)

Op 12 mei 2013 om 23:52 heeft Jesse Farebrother [email protected]

het volgende geschreven:

If your following that tutorial you should see its retrieved from the
associative array called params. When the request is first made
$params['client_details'] is populated with the information. So to access
it you would therefore use $params['client_details']['auto_approve'].
Sorry
for the lack of formating I'm on my phone.
On May 12, 2013 3:46 PM, "Alex Bouma" [email protected] wrote:

I know that. But I do not wish to change it but retrieve at as in the
tutorial!

—
Reply to this email directly or view it on GitHub<
https://github.com/php-loep/oauth2-server/issues/55#issuecomment-17785984>

.

—
Reply to this email directly or view it on
GitHub<
https://github.com/php-loep/oauth2-server/issues/55#issuecomment-17786079>

.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/55#issuecomment-17786140
.

[JesseFarebro]

Yeah it looks like in the default model that I said in my last post doesn't include the client_details however that would be very easy to implement just modify the SQL queries in your Client model and return an extra key in the associative array call it what ever you'd like.

[stayallive]

Yeah I can fix it but I think it should be fixed in the source too because im not the only one using the default PDO implementations I suppose. I can write You an pull request if wanted. If not please do fix so I can use the lib without modifying or implementing the storage models myself. :)

[alexbilbie]

This is an oversight on my part. I will update the wiki and PDO driver with how to make use of the auto-approve feature.

Emailing from my iPhone like a BOSS

On 12 May 2013, at 15:05, Alex Bouma [email protected] wrote:

Yeah I can fix it but I think it should be fixed in the source top because im not the only one using the default PDO implementations I suppose. I can write You an pull request if wanted. If not please do fix so I can use the lib without modifying or implementing the storage models myself. :)

—
Reply to this email directly or view it on GitHub.

[alexbilbie]

Closing this because it has been fixed in the imminent 3.0