Comments (2)
@arendjantetteroo thanks for reporting the issue.
To me this is not really an issue and I will try to explain why.
Period::getDatePeriod
returns aDatePeriod
instance.DatePeriod
instance when iterated over only returnsDateTimeInterface
objects. The instance of the object is determined by how theDatePeriod
start date was instantiated.- The package guarantees that the
DatePeriod
instance returned when iterate over will only returnDateTimeImmutable
instances. - In version 4
League\Period\Datepoint
extendsDateTimeImmutable
. (This is no longer the case in version 5) - if for whatever reason you created a
Period
instance with its start date endpoint being aLeague\Period\Datepoint
then theDatePeriod
instance created byLeague\Period\Period::getDatePeriod
will generateLeague\Period\Datepoint
instances.
So Period::getDatePeriod
does honour its contract. The issue here is that you expect that it will always return a Datepoint
instance which is not true and not part of any contract.
from period.
@nyamsprod ok thanks for clearing that up and the fast reply.
I wrongly assumed that DatePeriod was part of the Period package, while its a php core thing. It's weird this worked in 4.11 and doesn't in 4.12 though.
I'll use my workaround to create datepoints from any object it returns, this will probably be needed anyway in version 5.
from period.
Related Issues (20)
- Period::split() return Sequence HOT 1
- Is v3.x still stable and secure for PHP >=5.6 compatible environments (WP Plugins) HOT 1
- Can the lib handle periods without/ignoring year? HOT 3
- Number of (over)nights HOT 3
- Possible to determine the end of a duration in a sequence? HOT 2
- Navigation on docs page seems broken HOT 2
- Quotation marks in Iso80000 range cause an exception HOT 2
- Missing tests HOT 4
- Add support for PHP8.2
- Type hinting `|Type[]` returns, when not a technical possibility HOT 2
- Sequence has multiple same period ,call the intersections func ,result is error HOT 5
- Adding the boundaryType to Period named constructors ?
- Period without end HOT 3
- Add ability to associate additional custom data to a Period HOT 12
- Create from ISO8601 string HOT 11
- Merge sequences. (Logical OR similar to subtract which is logical NOT) HOT 1
- Missing Period in Sequence intersections. HOT 5
- sequence subtraction bug HOT 1
- Merge Bakame/Period-Visualizer codebase to the Period repo HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from period.