GithubHelp home page GithubHelp logo

Comments (6)

jzabroski avatar jzabroski commented on May 27, 2024 1

It makes sense for me to create a repro. Thanks for your explanation as you march towards improving the docs!

from snapper.

theramis avatar theramis commented on May 27, 2024

Hmmm I'm not sure why this is an issue with the current version of Snapper.

Snapper compares snapshots by converting it to a JObject first and then compares the stored snapshot and the new snapshot. By converting it to JObject it should remove all line endings from being a factor.

Would it be possible for you to create a quick demo of this?

from snapper.

jzabroski avatar jzabroski commented on May 27, 2024

Perhaps the internal comparison is correct, but it writes out the latest version with change in line endings.

I will see if updating Snapper helps - if there was a previous fix for this please let me know. Thank you.

from snapper.

theramis avatar theramis commented on May 27, 2024

Perhaps the internal comparison is correct, but it writes out the latest version with change in line endings.

Hmm that is quite odd behaviour. It shouldn't update the file unless there was a difference and update snapshots is set.

I will see if updating Snapper helps - if there was a previous fix for this please let me know. Thank you.

Not that I can think of. The behaviour as always been this. If the latest version doesn't solve the issue would it be possible for you to make a quick project with this issue?
You could add a test into Snapper and make a PR. The PR build runs on a windows instance so if the test was made using linux the line endings issue should be there.

Sorry I can't be of more help.

from snapper.

theramis avatar theramis commented on May 27, 2024

Hey @jzabroski, did you end up figuring out the problem was?

from snapper.

theramis avatar theramis commented on May 27, 2024

Closing this issue as its been a couple of months and nothing has come of it.

from snapper.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.