GithubHelp home page GithubHelp logo

Comments (3)

lmars avatar lmars commented on August 26, 2024

This is largely implemented in this commit (which is on the prevent-slow-retrieval-attacks branch).

However, the implemented timeoutReader has the side effect that if the given []byte is larger than chunkSize and the underlying reader returns partial data, those partial reads will be buffered until enough chunks have been read.

This may not be an issue, but it needs some thought, and probably needs testing against a real (and slow) HTTP server.

from go-tuf.

titanous avatar titanous commented on August 26, 2024

It looks like net/http's Request.Body.Close() could be dangerous here: golang/go#9662

Though I think it is easier to mitigate on the client side with CancelRequest.

from go-tuf.

mnm678 avatar mnm678 commented on August 26, 2024

Slow retrieval attacks were removed from the TUF spec.

from go-tuf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.