GithubHelp home page GithubHelp logo

Hard coded logging locations about puppet-bind HOT 5 OPEN

thias avatar thias commented on July 21, 2024
Hard coded logging locations

from puppet-bind.

Comments (5)

hybby avatar hybby commented on July 21, 2024

I raised a PR (#81) to address my immediate use case, but I recognise that a more flexible approach might be preferred.

from puppet-bind.

nickchappell avatar nickchappell commented on July 21, 2024

@hybby my PR from awhile ago may be of interest/use: #57

from puppet-bind.

hybby avatar hybby commented on July 21, 2024

@nickchappell - oh, excellent! This looks great. I'll close my PR, as it looks like you spent a bit more time on making things lovely and configurable. Thanks for sharing!

I hope that @thias has time to look at and merge your PR soon, as it would be a great contribution.

from puppet-bind.

ybrock avatar ybrock commented on July 21, 2024

Please implement this. I'm afraid of the newrelic-forks version, as the commits are very old in this repo.

If logging is not configurable, could you consider at least not hardcoding the template ? This way it would be possible to specify the template to use as a parameter, without starting to make local commits to the module.

from puppet-bind.

sshipway avatar sshipway commented on July 21, 2024

I have created PR #105 which makes all the logging options configurable

from puppet-bind.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.