GithubHelp home page GithubHelp logo

Comments (2)

rclough avatar rclough commented on July 19, 2024

This would be a cool feature, here's 2 ideas I have for it:

  1. A "start from step " option that starts any workflow from a given step
  2. A "mark step as completed" option which might be cleaner. Ie after manual intervention, you mark the step as successful and the dependency chain continues as normal.

1 has additional use cases beyond failures, ie you have bad data from one point on so there's no explicit failure, but you dont want to run the whole job again. 2 is probably the simplest fix simply for manually correcting errors like in your use case.

from dagobah.

thieman avatar thieman commented on July 19, 2024

I think we'd want to do a slight variant on 2. Instead of marking as completed, we should add a fourth task state representing a skipped job. Job states currently include waiting, running, and failed. These states are used to determine what actions are possible at any given time: https://github.com/thieman/dagobah/blob/master/dagobah/core/components.py#L49

I think the clarity of adding a fourth state would be worth the extra effort. It would be weird to get a job completed email that told you Task 7 was completed when in fact you skipped it.

You should be able to manually mark a task as skipped in the UI and then retry the job. Skipped tasks should be counted as "completed" for the purposes of graph traversal and job completion.

from dagobah.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.