3.0.0 Release Candidate about ng-bootstrap-form-validation

[jedsmith13]

@third774 Thanks for being willing to look into this.

I was able to create this on a blank Angular CLI project with just this module added #repo to clone.

If it helps here is my ng version info.

Angular CLI: 6.2.0
Node: 10.7.0
OS: linux x64
Angular: 6.1.7
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.8.0
@angular-devkit/build-angular     0.8.0
@angular-devkit/build-optimizer   0.8.0
@angular-devkit/build-webpack     0.8.0
@angular-devkit/core              0.8.0
@angular-devkit/schematics        0.8.0
@angular/cli                      6.2.0
@ngtools/webpack                  6.2.0
@schematics/angular               0.8.0
@schematics/update                0.8.0
rxjs                              6.2.2
typescript                        2.9.2
webpack                           4.17.2

[joshuataylor]

Does this build for you? yarn start works, but yarn build results in:

ERROR in Error during template compile of 'AppModule'
  Function calls are not supported in decorators but 'NgBootstrapFormValidationModule' was called.

node 10.9.0

edit:
It looks like it creates a node_modules folder inside the ng-bootstrap-form-validation folder?

$ ls node_modules/ng-bootstrap-form-validation/node_modules/
@angular  rxjs  symbol-observable

edit: rm -rf node_modules/ng-bootstrap-form-validation/node_modules/ then a yarn build works. Need to make sure node_modules is not added.

[joelmuskwe]

Please try yarn add ng-bootstrap-form-validation@next or npm i ng-bootstrap-form-validation@next
That problem was in the previous version when you were working with angular 6 if it doesn't work trying clearing either your npm or yarn cache and reinstall the library.

[joshuataylor]

That's what I have done already, I've deleted yarn.lock, node_modules, and ~/.yarn.

When doing another yarn add ng-bootstrap-form-validation@next (after deleting the existing "ng-bootstrap-form-validation": "^2.1.0-dev.20180903041904043Z.89a37902a6d131f1a0969eaf3c402cd9011ddcfc", from package.json, it seems to work, and deleting node_modules and running yarn again works now... very strange.

Cheers!

[jedsmith13]

I am getting the same error:

ERROR in Error during template compile of 'AppModule'
  Function calls are not supported in decorators but 'NgBootstrapFormValidationModule' was called.

I have the same version as @joshuataylor:

"ng-bootstrap-form-validation": "^2.1.0-dev.20180903041904043Z.89a37902a6d131f1a0969eaf3c402cd9011ddcfc",

I have cleared my npm cache, removed ng-bootstrap-form-validation, and reinstalled using:

npm i ng-bootstrap-form-validation@next

I don't have the node_modules folder @joshuataylor had, but it still isn't working.

[third774]

Thanks for the reports @jedsmith13 and @joshuataylor!

I won't have time to look into this until this weekend. If anyone is able to reproduce with a repo I can clone, that would be super helpful!

[joelmuskwe]

Will try to take a look at it too

[joelmuskwe]

Fixed the ERROR in Error during template compile of 'AppModule' bug refer to pull request #45

[third774]

@jedsmith13 - can you try installing ng-bootstrap-form-validation@next again and see if it works now? Should be all good after that PR from @joelmuskwe

[joshuataylor]

Can confirm that builds now work correctly 🎉

Thanks so much everyone!

[jedsmith13]

@third774 and @joelmuskwe It works, Thanks.