Comments (4)
I believe this is just extra learning and writing requirement for us, the users, besides being hard to explain to others what is that. It should and could be more plug n' play
from actions-comment-pull-request.
@thollander Solution you proposed requires code duplication and complexity that could be hidden behind implementation.
See how much simpler this looks and how less error prone it is:
message: |
Current branch is `${{ github.head_ref }}`.
_(execution **${{ github.run_id }}** / attempt **${{ github.run_attempt }}**)_
comment_tag: current-branch
from actions-comment-pull-request.
@thollander Could this be done?
There is also this to avoid two results for the same string search: https://stackoverflow.com/a/70566764/20234776
from actions-comment-pull-request.
Thanks for the improvement idea !
Why can't you use the comment_includes
parameter to do so ?
It has the benefit to be generic and you can put whatever you want as comment pattern.
Example here : https://github.com/thollander/actions-comment-pull-request/pull/156/files
message: |
Current branch is `${{ github.head_ref }}`.
_(execution **${{ github.run_id }}** / attempt **${{ github.run_attempt }}**)_
<!--- thollander/actions-comment-pull-request "comment_tag" --->
comment_includes: <!--- thollander/actions-comment-pull-request "comment_tag" --->
Would it match to your need ?
from actions-comment-pull-request.
Related Issues (20)
- Error when the PR is sent from a fork HOT 1
- Get `pr_number` when triggered by `issue_comment` HOT 1
- [FEATURE] Add ability to delete and re-create current comment HOT 4
- Comment content from a file HOT 1
- [Feature] Ability to specify a comment should NOT be created if its tag does not yet exist HOT 3
- Failure with NPM and stack overflow while building this action image HOT 10
- When filePath is absolute GITHUB_WORKSPACE shouldn't be joined HOT 2
- Question/Request: Is it possible to delete a comment without creating a new one? HOT 2
- Update a specific comment that was not created by this action? HOT 1
- [v2.3.1] Resource not accessible by integration HOT 6
- Possibility to comment with a clickable images / badges with a link HOT 1
- README update HOT 10
- Abstain from renaming branches HOT 4
- Unable to resolve `master` version HOT 2
- Proper versionning
- HttpError: Resource not accessible by integration HOT 2
- Using branches-ignore with comment-pull-request runs workflow when branch is set to be ignored HOT 1
- incompatible with lockfileversion2
- How I can get a output of a file commented ? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from actions-comment-pull-request.