GithubHelp home page GithubHelp logo

Comments (4)

SrBrahma avatar SrBrahma commented on June 24, 2024 2

I believe this is just extra learning and writing requirement for us, the users, besides being hard to explain to others what is that. It should and could be more plug n' play

from actions-comment-pull-request.

lukasz-mitka avatar lukasz-mitka commented on June 24, 2024 1

@thollander Solution you proposed requires code duplication and complexity that could be hidden behind implementation.
See how much simpler this looks and how less error prone it is:

          message: |
            Current branch is `${{ github.head_ref }}`.
            _(execution **${{ github.run_id }}** / attempt **${{ github.run_attempt }}**)_
          comment_tag: current-branch

from actions-comment-pull-request.

SrBrahma avatar SrBrahma commented on June 24, 2024

@thollander Could this be done?

There is also this to avoid two results for the same string search: https://stackoverflow.com/a/70566764/20234776

from actions-comment-pull-request.

thollander avatar thollander commented on June 24, 2024

Thanks for the improvement idea !
Why can't you use the comment_includes parameter to do so ?
It has the benefit to be generic and you can put whatever you want as comment pattern.

Example here : https://github.com/thollander/actions-comment-pull-request/pull/156/files

          message: |
            Current branch is `${{ github.head_ref }}`.
            _(execution **${{ github.run_id }}** / attempt **${{ github.run_attempt }}**)_
            <!--- thollander/actions-comment-pull-request "comment_tag" --->
          comment_includes: <!--- thollander/actions-comment-pull-request "comment_tag" --->

Would it match to your need ?

from actions-comment-pull-request.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.