Unreadable variable names about sunfish

[abhinuvpitale]

Adding a flake8 test would help this codebase.

[thomasahle]

I agree with you in general, and it's possible that the code should be rewritten that way. For this project I have instead tried to keep everything small, but consistent. Having longer variable names would make some lines too long, and I don't want to split them up.

I agree that some documentation would be nice though. Like wc means "white casting", bc "black castling", i and j are always "from square" and "too square", p and q are "from piece" and "too piece".

[Recursing]

I think names like i and j would be very easy to improve, would you be willing to accept a pull request that tries to improve readability without breaking the 80 character limit?

Also using black or autopep8 would make the code more consistent without impacting the line number

[thomasahle]

Fair, better names for i and j are a good idea. Maybe fs, ts to fit with the convention? :-)

I think autopep8 and black will disagree with the use of inline ifs in sunfish.

But I'm happy to discuss any pull request.