GithubHelp home page GithubHelp logo

Comments (3)

ThomasAribart avatar ThomasAribart commented on May 28, 2024

Hi @hamanuha and thanks for reaching out!

This seems to be related to #165, you can look at https://github.com/ThomasAribart/json-schema-to-ts/blob/main/documentation/FAQs/applying-from-schema-on-generics.md

This worked for me:

type ContractRouteImplementation<
  CONTRACT_ROUTE extends ContractRoute,
  PARAMS = FromSchema<CONTRACT_ROUTE["params"]>,
  QUERY = FromSchema<CONTRACT_ROUTE["query"]>,
> = () => {
  handler: (request: { Params: PARAMS; Query: QUERY }) => void;
};

from json-schema-to-ts.

hamanuha avatar hamanuha commented on May 28, 2024

Hi @ThomasAribart,

thanks for the hint. Unfortunately this does not work for me.
I am using typescript 5.3.3. Maybe it's related to some config values?

Would you mind sharing your tsconfig?

Edit:
When using your asConst function it works with both versions of the ContractRouteImplementation.
But only if I use as const as well.

const contract = initContract({
  demo: {
    params: asConst({
      type: 'object',
      properties: {
        str: { type: 'string' },
      },
      required: ['str'],
      additionalProperties: false,
    } as const),
    query: externSchema,
  },
})

Edit2:
When using the Narrow type from your package inside FromSchema it works also for the inline schema without having to use asConst

type ParamsFromSchema<T extends ContractRoute, TParams = Narrow<T['params']>> = TParams extends JSONSchema
  ? FromSchema<TParams>
  : never

from json-schema-to-ts.

hamanuha avatar hamanuha commented on May 28, 2024

Hey @ThomasAribart,

did you see my second edit?
Can I help with something to resolve this issue?

from json-schema-to-ts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.