GithubHelp home page GithubHelp logo

colmar's People

Contributors

thomasbromehead avatar

Watchers

 avatar

colmar's Issues

HTML nesting

Colmar/index.html

Lines 41 to 51 in fb7ee24

<div class="container supporting-1">
<div class="img-holder">
<img src="images/banner.jpg">
</div>
<div class="info">
<h1>Learn something new everyday</h1>
<p>Lorem ipsum dolor sit amet, consectetur adipisicing elit.</p>
<button>Start here</button>
</div>
</div>

Most of your HTML looks good, but make sure to keep it all neat by properly nesting! You have a couple of divs out of place here.

Connecting CSS to HTML

<link href="Resources/style.css" rel="stylesheet" type="text/css"/>

I'm not sure if this worked on your computer, but be sure to properly link your CSS file. You forgot to add the './' at the beginning of your href, so when I load your code, it shows up with no styling. This is how it should be:

<link href="./Resources/style.css" rel="stylesheet" type="text/css"/>

Grade: Meets Expectations

Good job with this project! You had a couple of minor issues with line breaks, HTML nesting, and linking your CSS file, but your code is effective and clear! I'd mostly recommend going through your code and organizing it better; a little bit of organization goes a long way in making your code look professional.

Occasional weird CSS spacing

Colmar/Resources/style.css

Lines 238 to 271 in fb7ee24

margin: 2rem 2rem;
}
.tiles .content{
width:65%;
}
.tiles .content a{
font-family:Oswald;
font-size:2.25rem;
margin-top:0;
}
.tiles .content p{
margin: 1rem 0;
}
#signature{
font-size:1.8rem;
font-weight:bold;
}
/*3rd main div*/
.container>h1{
margin:4rem 0;
text-align: center;
}

Just a minor issue, but try to keep your code neat by eliminating these unnecessary line breaks

img-holder .img:nth-of-type

Hello team,
I successfully removed the man reading the journal along with the description underneath it by giving the div with class "img-holder" an id of "journal".
However I left it on so you give it a try with the nth-of-type selector.
I tried it but it also removes the image at the bottom.
There are a total of 3 img-holder divs...
Let me know if you manage to remove if from the DOM in that way, I would really like it to work in that way.
Thanks a lot, the courses are great, loved every bit of it!!

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.