GithubHelp home page GithubHelp logo

Comments (4)

thomasjohnkane avatar thomasjohnkane commented on May 18, 2024

Could we handle this with just having a method on the notification class like shouldStillSend() to check to see if sending is still required? You can already log that a notification was sent in the toArray() method of the notification class.

I'm going to create a PR for the should still send check, and we can discuss events down the road if there's a more concrete example.

from snooze.

atymic avatar atymic commented on May 18, 2024

I was actually thinking of doing it that way, but didn't have a chance to get it implemented yet :)

Thanks for doing the PR, will check it out now :)

I think it's probably still worth firing an event on sent (at least)

from snooze.

LeonAlvarez avatar LeonAlvarez commented on May 18, 2024

Is this implemented?

from snooze.

atymic avatar atymic commented on May 18, 2024

@LeonAlvarez

Yep:
https://github.com/thomasjohnkane/snooze/blob/master/src/Models/ScheduledNotification.php#L77

from snooze.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.