[Opinion] "Edit Element/Keyboard Style" should only appears when in the edit-mode. about nohboard

[ThoNohT]

It is currently separate from that because style editing was possible before there even was an edit mode. I guess I should reconsider whether they should not be moved to be edit mode specific as well. I'll give this some thought.

[joao-mambelli]

I thought exactly that. And i think it would be more clean look after the change

[ThoNohT]

Implemented in 12349fc

[joao-mambelli]

You implemented but kept the separator and the "Edit" word before the buttons... just to know: you made on purpose or just forgot? I mean, the separator is not a big deal but if you are already IN the edit-mode, the word "Edit" is redundant. And for example you also didn't put "Edit" in the "Element Properties" button...

[ThoNohT]

Ah, the "Edit", I didn't even look at that. I guess I can remove that too.

[ThoNohT]

Right, I removed the Edit, I do want to keep the separator there. I like a bit of separation between those forms and the actual direct actions.