Correctly handle \n when writing file about amun-api

[goern]

hmm, we should provide a container image name to amun to execute that, this container image should include the microbenchmark.

[saisankargochhayat]

https://paste.ofcode.org/PrLfLsKSwuUr4LamXQvFaN
This is what the create_dockerfile return's when I tried passing the sample from the stage amun link, if I delete the part above FROM, it seems to build as a docker image also, is that what we were expecting? I am not sure.

[fridex]

Check the input string - on the API endpoint, there is requested:

  "script": "#!/usr/bin/bash\necho \"Here should be run tests...\"\n",

that is transformed to (based on your paste):

RUN echo -e "#!/usr/bin/bash\n\\necho \"Here should be run tests...\"\n\\n" > "/home/amun/script"

I think the expected content of the file is (based on the API endpoint input):

#!/usr/bin/bash
echo "Here should be run tests..."

Will the echo invocation (as done in the generated Dockerfile) produce same file as desired?

[saisankargochhayat]

I think they produce the same result, do you want the extra space to be removed?

[fridex]

do you want the extra space to be removed?

it would be great if they match

[saisankargochhayat]

This would be just for the value of the key script right?

[fridex]

I think it applies to all the _write_file_string invocations:

amun-api/amun/dockerfile.py

Line 76 in bcdfc3b

def _write_file_string(content: str, path: str) -> str:

So also for writing the lock file, requirements file or pip configuration.

[goern]

whats the status of this?