GithubHelp home page GithubHelp logo

Comments (11)

geoffharcourt avatar geoffharcourt commented on August 10, 2024

One more item: if I rewind to the previous commit (94a256b), the problem is resolved.

from vim-rspec.

kbredemeier avatar kbredemeier commented on August 10, 2024

Same problem for me using vim-slime

from vim-rspec.

gylaz avatar gylaz commented on August 10, 2024

I've reverted 4c637bd as I realized that it wasn't thought through well enough.

from vim-rspec.

geoffharcourt avatar geoffharcourt commented on August 10, 2024

@gylaz, thanks very much for the quick fix.

from vim-rspec.

chibicode avatar chibicode commented on August 10, 2024

👍

from vim-rspec.

neektza avatar neektza commented on August 10, 2024

This is still happening for me when using vim-rspec and vim-dispatch together.

In my .vimrc I have:

let g:rspec_command = "Dispatch rspec {spec}"
let g:rspec_runner = "os_x_iterm"

The whole command (Dispatch rspec spec/models/users_spec.rb) gets dumped to the console when it should be run by Vim instead.

When using only vim-dispatch (Dispatch rspec %) everything works fine.

from vim-rspec.

tomaszwojcik avatar tomaszwojcik commented on August 10, 2024

Same issue as @neektza. Whole Dispatch command is send to the console on MacVim GUI, however on terminal Vim it works fine.

from vim-rspec.

ainformatico avatar ainformatico commented on August 10, 2024

Same issue here.

from vim-rspec.

keith avatar keith commented on August 10, 2024

I was able to reproduce this error with the commands mentioned by @neektza running in MacVim. The command being created is:

!/path/to/vim-rspec/bin/os_x_iterm 'Dispatch rspec {spec}'

We should be letting dispatch handle all of this. Then the command would just be:

Dispatch rspec {spec}

from vim-rspec.

gylaz avatar gylaz commented on August 10, 2024

I've been thinking about this, and I think a reasonable solution is not to default a g:rspec_runner, but to force the user to set it if they want to use one. This would allow for the use case of this issue.

from vim-rspec.

kurioscreative avatar kurioscreative commented on August 10, 2024

Was there ever a resolution of this issue? I can confirm that it is still happening for me on Macvim and iTerm2.

from vim-rspec.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.