[watermill-amqp] panic: cannot open channel: Exception (504) Reason: "channel id space exhausted" about watermill

[duolabmeng6]

rabbitmq

[duolabmeng6]

func (p *Publisher) Publish(topic string, messages ...*message.Message) (err error) {
	if p.closed {
		return errors.New("pub/sub is connection closed")
	}
	p.publishingWg.Add(1)
	defer p.publishingWg.Done()

	if !p.IsConnected() {
		return errors.New("not connected to AMQP")
	}

	channel, err := p.amqpConnection.Channel()
	if err != nil {
		return errors.Wrap(err, "cannot open channel")
	}
	defer func() {
		if channelCloseErr := channel.Close(); channelCloseErr != nil {
			err = multierror.Append(err, channelCloseErr)
		}
	}()

How to reuse channel

[duolabmeng6]

func (p *Publisher) NewChannel(){
	p.Channel, _ = p.amqpConnection.Channel()
}
func (p *Publisher) Publish2(topic string, messages ...*message.Message) (err error) {
	//if p.closed {
	//	return errors.New("pub/sub is connection closed")
	//}
	//p.publishingWg.Add(1)
	//defer p.publishingWg.Done()
	//
	//if !p.IsConnected() {
	//	return errors.New("not connected to AMQP")
	//}
	//
	//p.channel, err := p.amqpConnection.Channel()
	//if err != nil {
	//	return errors.Wrap(err, "cannot open channel")
	//}
	//defer func() {
	//	if channelCloseErr := channel.Close(); channelCloseErr != nil {
	//		err = multierror.Append(err, channelCloseErr)
	//	}
	//}()

	//if p.config.Publish.Transactional {
	//	if err := p.beginTransaction(channel); err != nil {
	//		return err
	//	}
	//
	//	defer func() {
	//		err = p.commitTransaction(channel, err)
	//	}()
	//}

	//if err := p.preparePublishBindings(topic, channel); err != nil {
	//	return err
	//}

	logFields := make(watermill.LogFields, 3)

	exchangeName := p.config.Exchange.GenerateName(topic)
	logFields["amqp_exchange_name"] = exchangeName

	routingKey := p.config.Publish.GenerateRoutingKey(topic)
	logFields["amqp_routing_key"] = routingKey

	for _, msg := range messages {
		if err := p.publishMessage(exchangeName, routingKey, msg, p.Channel, logFields); err != nil {
			return err
		}
	}

	return nil
}

I try add NewChannel()

Publish2() Just use a channel

now incoming Achieve 13000/s

[roblaszczak]

Hello, Publish is implemented without Channel reusing to ensure that all messages are sent after Publish was executed (so in other words if your service will die you are sure that all messages were sent :) ).

If it is fine for you that you may lose some messages in this case - channel can be reused. I think that you can post PR with adding the configuration option for reusing channels if you have some time.

[duolabmeng6]

Hello, brother, are you free? Can you help me to add the option of multiplexing channel? Thank you very much

This is very helpful for improving performance

Up to 10000+ / S