Comments (6)
Ideally, Watermill's
amqp.NewSubscriber
method would automatically reuse a single connection, creating instead a new Channel
The same could apply to publishers as well. For instance I'm working on a "processor" of sorts which acts on messages in one queue and outputs new messages to an output queue via a publisher. Currently watermill would create two connections, one for the subscriber and one for the publisher.
If this isn't feasible, please consider adding a new method that accepts an existing
*amqp.Connection
parameter (vs the current amqp.Config param.)
In this case you'd lose all benefits of having watermill take care of connection management for you. I think it'd be better if watermill somehow exposed the internal connection manager and allowed us to re-use that instead.
Another thing I noticed while looking at watermill's AMQP package is that an AMQP channel is created for each publish, which also isn't recommended. (Citation.)
In an ideal world the AMQP connection should be created once (unless you need multiple configs), the subscriber channel should be created once (per subscriber) & be long-lived and the same goes for the publisher channel.
from watermill.
Hello, I will be happy to merge any changes that are working and not affecting current functionality and flexibility :)
Feel free to experiment, with current tests It should be pretty simple. If you need any help, please hit me on Gophers slack so I can help. To make it easier, I shared some tribal knowledge about how I do debugging of the tests here: https://watermill.io/docs/troubleshooting/#debugging-pub-sub-tests
from watermill.
I have a pull request open that (hopefully) resolves this issue: ThreeDotsLabs/watermill-amqp#9. Please review. Thx! @roblaszczak @ferbs @jawr @raqbit
from watermill.
An extension of this would mean we could remove/stop router handlers dynamically. At the moment the Handler shutdown process attempts to close the subscriber, which if shared would be undesired.
from watermill.
@bstasyszyn I've switched off the project using watermill-amqp so will go silent (leaving this issue open.)
from watermill.
PR was merged: ThreeDotsLabs/watermill-amqp#9. This issue can be closed.
from watermill.
Related Issues (20)
- How to delete message after ack? HOT 1
- Context not being propagated through command bus HOT 2
- Is it possible to get google pubsub server generated unique message-id? HOT 3
- Data race on Publish for Google pubsub
- SQLite driver HOT 4
- Log custom fields inside message router
- Invalid publisher name in metrics
- Resume after shutdown always fetch last interrupted message again
- How to process a batch of received messages instead of a single piece?
- Can you output the message metadata to the logs?
- Only post messages after subscribing
- Watermill tests fail on windows
- The publish signature does not allow for a context.Context to be passed HOT 2
- Router closes publisher before message processing is done
- Removing usage of https://github.com/hashicorp/go-multierror
- [watermill-http] Custom HTTP response status HOT 2
- [watermill-kafka] is watermill-kafka still maintained? HOT 2
- example: server-sent-events-htmx: How to swap the PUB SUB system ? HOT 5
- HelloGitHub Badge HOT 1
- Update documentation to reflect ExactlyOnceDelivery for PostgreSQL Pub/Sub
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from watermill.