GithubHelp home page GithubHelp logo

Comments (5)

Prakhar-Agarwal-byte avatar Prakhar-Agarwal-byte commented on August 12, 2024 1

I think the difference in size is due to the icons in Prev and Next buttons. I will add some padding in the Finish button to fix this.

from padawan-wallet.

darkvoid32 avatar darkvoid32 commented on August 12, 2024 1

My bad, totally forgot about padding potentially being different for all screen sizes.

There should be a few good alternative ways of solving this (both prev and next buttons using the same row and filling up height etc..)

from padawan-wallet.

thunderbiscuit avatar thunderbiscuit commented on August 12, 2024

Yes something about the way the weight is distributed between the two buttons I think might be the cause. Somehow the "Prev" button keeps the same size across devices and the other button always just uses whatever space is left (not sure about this, just a feeling).

from padawan-wallet.

thunderbiscuit avatar thunderbiscuit commented on August 12, 2024

On my emulator it looks like this is not yet fixed. The buttons are closer in size, but not identical by default (and I don't think they're the same length).

I think the issue is that the fix in #300 is hard-coding a padding value, but that won't really fix the issue on all screen sizes.

from padawan-wallet.

thunderbiscuit avatar thunderbiscuit commented on August 12, 2024

Yeah agreed, I think the idea of the two buttons sharing a row and filling up the height + using each the same width proportion inside the row makes sense and will ensure they always just look the same.

from padawan-wallet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.