Comments (5)
I think the difference in size is due to the icons in Prev and Next buttons. I will add some padding in the Finish button to fix this.
from padawan-wallet.
My bad, totally forgot about padding potentially being different for all screen sizes.
There should be a few good alternative ways of solving this (both prev and next buttons using the same row and filling up height etc..)
from padawan-wallet.
Yes something about the way the weight is distributed between the two buttons I think might be the cause. Somehow the "Prev" button keeps the same size across devices and the other button always just uses whatever space is left (not sure about this, just a feeling).
from padawan-wallet.
On my emulator it looks like this is not yet fixed. The buttons are closer in size, but not identical by default (and I don't think they're the same length).
I think the issue is that the fix in #300 is hard-coding a padding value, but that won't really fix the issue on all screen sizes.
from padawan-wallet.
Yeah agreed, I think the idea of the two buttons sharing a row and filling up the height + using each the same width proportion inside the row makes sense and will ensure they always just look the same.
from padawan-wallet.
Related Issues (20)
- Get coins button leads to ANR HOT 4
- Adding a progress bar to Learn segment HOT 2
- Feature: The address should be present in the transaction details HOT 2
- Copy/Paste can't be done in the address section of send screen HOT 1
- Highlight the Bottom Navigation Tab HOT 3
- Feature: Option for choosing an image from gallery in QR Screen HOT 2
- Generating an address displays a different string for a moment HOT 4
- Database and backend discussion HOT 3
- Migrate LiveData objects to Kotlin Flows
- Mulitple clicks on navigation buttons open destinations multiple times HOT 1
- Scanner doesn't interpret BIP-21 URIs HOT 2
- Diagrams, images, and GIFs HOT 1
- "Recover it here" text button on onboarding screen has ripple effect HOT 1
- UX Design Philosophy HOT 2
- Potential features for a 2.0 release HOT 2
- Fix chapter 7 HOT 4
- Suggestion for: <string name="privacyText"> HOT 1
- Translate new string resources HOT 2
- Spanish Translation HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from padawan-wallet.