GithubHelp home page GithubHelp logo

Comments (2)

tiagopog avatar tiagopog commented on May 19, 2024

Making this helper method safe seems like a good idea for me and I will sure work on a refactoring asap.

Anyway, I'm curious on how you came to reach that error. Since :data is not present for the given operation and it probably requires the JSON body to be present (eg. POST, PUT, PATCH request), if an empty/bad formatted body is passed it should be verified and treated before calling the controller action.

from jsonapi-utils.

seanabrahams avatar seanabrahams commented on May 19, 2024

It was via a request like GET /profile/:profile_id/articles where it was looking for a profile_id in params[:profile_id] OR resource_params[:profile_id].

The question then is, why look in resource_params[:profile_id] if it's a GET request? The answer is that I'm trying to keep the code DRY and avoid a conditional like if request.get?.

Ultimately, calling resource_params, even on a GET request, should not throw an exception (in my opinion).

from jsonapi-utils.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.