Unable to properly close onUserData websocket api due to setInterval function inside it about binance

[karthik947]

I tried doing that. It closes the websocket. However, the setInterval function inside on onUserData steam keeps sending a request to binance to keep the socket alive, which is throwing errors.

…

On Fri, Jan 25, 2019 at 12:12 AM Chris ***@***.***> wrote: I believe your call to binanceWS.onUserData returns a WebSocket (npm package ws) which I think you can close by calling .close(). (see: https://github.com/websockets/ws/blob/HEAD/doc/ws.md#websocketclosecode-reason ) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/zoeyg/binance/issues/70#issuecomment-457309686>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcqnQz6ILT5WgD4Q0kYDHjh7bzoOCcQmks5vGf6EgaJpZM4aQYlL> .

-- Best Regards, Karthik.

[apexearth]

Woops you saw my comment quite fast.
I deleted it a moment later seeing I was a bit off from your problem.

[karthik947]

:) No worries. Thanks for taking time to respond.

…

On Fri, Jan 25, 2019 at 12:42 AM Chris ***@***.***> wrote: Woops you saw my comment quite fast. I deleted it a moment later seeing I was a bit off from your problem. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/zoeyg/binance/issues/70#issuecomment-457319828>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcqnQxBOwXDcAQKYxU5TA6nVs7jJ_iwUks5vGgWvgaJpZM4aQYlL> .

-- Best Regards, Karthik.

[apexearth]

It looks to me like you'll have to fork the repo and make a change.
Extend the WebSocket .close so it can close the setInterval.

Something like:

onUserData(binanceRest, eventHandler, interval = 60000) {
    return binanceRest.startUserDataStream()
        .then((response) => {
            let intervalId = setInterval(() => {
                binanceRest.keepAliveUserDataStream(response);
            }, interval);
            this._setupWebSocket(eventHandler, response.listenKey)
                .then(ws => {
                    ws.close2 = ws.close;
                    ws.close  = () => {
                        clearInterval(intervalId)
                        ws.close2()
                    }
                    return ws
                });
        });
}

[karthik947]

Thanks again , I will try it tomorrow and post here if that fixed the issue. On 25-Jan-2019 12:50 AM, "Chris" <[email protected]> wrote: It looks to me like you'll have to fork the repo and make a change. Extend the WebSocket .close so it can close the setInterval. Something like: onUserData(binanceRest, eventHandler, interval = 60000) { return binanceRest.startUserDataStream() .then((response) => { let intervalId = setInterval(() => { binanceRest.keepAliveUserDataStream(response); }, interval); this._setupWebSocket(eventHandler, response.listenKey) .then(ws => { ws.close2 = ws.close; ws.close = () => { clearInterval(intervalId) ws.close2() } }); }); } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/zoeyg/binance/issues/70#issuecomment-457322400>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcqnQ6QMOFywa1uQZGOADgScYM8TYdH7ks5vGgd-gaJpZM4aQYlL> .

[tiagosiebler]

If you PR a fix the clear the interval, I'll get it reviewed. I guess the logic would need to clear the interval if:

• keep alive returned an error, or
• the socket was manually closed

[zoeyg]

Could potentially use the code from this for a quick change for 1.x zoeyg/binance@aa7d0c4