Comments (3)
Hey @JacobBennett,
I know how to do it, but thank you anyway :) I simply stumbled upon this and haven't had time earlier to fix it (didn't know you could online-edit)
Beside that:
It's awesome to see how you take time to explain the GitHub workflow to beginners. π I would have loved to have someone like you explain this to me when I started out.
Best,
Sebastian
from gistlog.
Good catch on this @hiwye! Would you like to make a PR on this. Would love to have you contribute to this project and this would be a good way to start.
All you would have to do is go to
https://github.com/tightenco/gistlog/blob/master/app/Gists/Comment.php#L47
which is the broken page, and click the pencil icon in the top right corner to edit
Make the necessary change and then type up a short description, or reference this issue by typing #106 in the description. Then just press the propose file change button at the bottom.
Good luck! Look forward to seeing your PR. If you have any questions feel free to respond here or hit me up on twitter @JacobBennett
from gistlog.
Glad to help @hiwye! I remember being so intimidated when I submitted my first PR, oddly enough on this project I believe, and being so excited when it got pulled in! Love sharing that excitement with other folks in the community. In any case, thanks for the PR. Feel free to look around the codebase or browse through the other issues to see if there is anything else you are up to tackling π
Have a good one!
from gistlog.
Related Issues (20)
- Increase performance and caching of Gists HOT 2
- Load comments via AJAX so the initial page load isn't slow HOT 3
- Matt broke GitHub comment auth when upgrading Laravel
- Expose an RSS/Atom feed for a userβs page
- Landing page content seems to take a while to update HOT 2
- Shouldn't this be a static site? HOT 8
- Anchors aren't auto-generated for headers like in GitHub HOT 5
- Breaks at whitespace not respected in Anchor elements HOT 8
- Some small style rendering issues HOT 1
- Line height in bullet lists is too small HOT 1
- Show count of stars for a given post HOT 2
- Viewing Github Profile info below Profile Image HOT 2
- Upgrade dependencies including guzzle.
- Add Bugsnag HOT 3
- Ignore 404s on Bugsnag
- Add the count of comments to the "Comments" header, like it's shown at the top of the page
- If user isn't signed in, show the "star" button grey and pop up a signin prompt if they tap it
- Close modal when the user presses "esc" key
- Fix star/comment buttons on Safari desktop HOT 5
- Consider options for looking up and caching stargazercount that allow non-logged-in users to see them
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gistlog.