Comments (11)
Are you thinking to have some sort of medium style in-line comments?
from gistlog.
Not for now--I really just mean "Allow for the ability to add, not just view, Github's native comments directly from Gistlog."
Great question; updating title.
from gistlog.
For the time being, just a link to gist.github.com that says "Comment on GitHub" would be nice?
Great job with gistlog, by the way, the posts look amazing.
from gistlog.
hey @mattstauffer I was thinking of trying to implement this with Socialite for login to the gistlog app, then use Vue.js to build out a comment form. Thoughts before I start in on this?
from gistlog.
@JacobBennett Yah, optional Socialite login would be great. The flow of how/when/etc. for authorization is going to be interesting, so I'm very interested to see what you do for that. :)
RE: Vue... is there any reason to do it VueJS rather than just good ol' plain ol' HTML/CSS? If there's a particular user flow that you want to work on, for sure, but if it's just going to submit like any old page, it sounds like a lot of extra work for no benefit. But again, if you have a particular concept that Vue could make possible, I'm 100% for it!
from gistlog.
@mattstauffer I need to figure out the flow for the Socialite login is as well I suppose. I guess I was under the impression that in order to post comments you had to be logged in through GitHub. I'm not positive if that is the case or not.
Secondly, in regards to Vue, I have been looking for a reason to use it, and an asynchronous comment box seems like the ticket on this. Add the comment as soon as they press submit, and send the update to GitHub via ajax.
Maybe on the first pass I'll do it using straight up HTML/CSS as a MVP but would like to see it be all fancy π
from gistlog.
@JacobBennett I meant optional only that I want non-logged-in-users to have a first class reading experience, so we should make the log in flow be only at comment-leaving time for now. :)
Haha, that sounds fine--my concern with Vue would be auth + CORS + GitHub being a huge pain... which means you're really going to be doing Vue -> ajax -> gist log servers -> github sdk -> github.. which is a lot. So yah.. if I were you, I'd get it working sans Vue first, then do a Vue version second. Will save you some pain IMHO :)
from gistlog.
@mattstauffer agreed about the reading experience, will look similar to how it looks for someone on a gist that isn't logged in.
The user would be able to read comments without being logged in, but upon wanting to comment would be prompted for authorization. Would use Socialite to create a user with a remember token and a login forever sort of deal on Gistlog, or until the token expires.
from gistlog.
Fantastic. Check out out Giscus does it; really similar flow.
On Sat, Aug 15, 2015 at 10:42 PM, Jacob Bennett [email protected]
wrote:
@mattstauffer https://github.com/mattstauffer agreed about the reading
experience, will look similar to how it looks for someone on a gist that
isn't logged in.[image: image]
https://cloud.githubusercontent.com/assets/1517011/9291729/406afd3c-4396-11e5-9a26-659db5e7b57a.pngThe user would be able to read comments without being logged in, but upon
wanting to comment would be prompted for authorization. Would use Socialite
to create a user with a remember token and a login forever sort of deal on
Gistlog, or until the token expires.β
Reply to this email directly or view it on GitHub
#7 (comment).
Matt Stauffer
Partner + Technical Director
Tighten Co.
352-682-2765
from gistlog.
@mattstauffer Got Github Auth and comments on Gists working last night. Cleaning up code and starting in on UI. Excited to add this feature!
from gistlog.
Woo! Can't wait to see it!
On Mon, Aug 17, 2015 at 9:17 AM, Jacob Bennett [email protected]
wrote:
@mattstauffer https://github.com/mattstauffer Got Github Auth and
comments on Gists working last night. Cleaning up code and starting in on
UI. Excited to add this feature!β
Reply to this email directly or view it on GitHub
#7 (comment).
Matt Stauffer
Partner + Technical Director
Tighten Co.
352-682-2765
from gistlog.
Related Issues (20)
- Increase performance and caching of Gists HOT 2
- Load comments via AJAX so the initial page load isn't slow HOT 3
- Matt broke GitHub comment auth when upgrading Laravel
- Expose an RSS/Atom feed for a userβs page
- Landing page content seems to take a while to update HOT 2
- Shouldn't this be a static site? HOT 8
- Anchors aren't auto-generated for headers like in GitHub HOT 5
- Breaks at whitespace not respected in Anchor elements HOT 8
- Some small style rendering issues HOT 1
- Line height in bullet lists is too small HOT 1
- Show count of stars for a given post HOT 2
- Viewing Github Profile info below Profile Image HOT 2
- Upgrade dependencies including guzzle.
- Add Bugsnag HOT 3
- Ignore 404s on Bugsnag
- Add the count of comments to the "Comments" header, like it's shown at the top of the page
- If user isn't signed in, show the "star" button grey and pop up a signin prompt if they tap it
- Close modal when the user presses "esc" key
- Fix star/comment buttons on Safari desktop HOT 5
- Consider options for looking up and caching stargazercount that allow non-logged-in users to see them
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gistlog.