GithubHelp home page GithubHelp logo

Reduce some internal panics. about raft-rs HOT 2 CLOSED

tikv avatar tikv commented on August 28, 2024
Reduce some internal panics.

from raft-rs.

Comments (2)

JoshMcguigan avatar JoshMcguigan commented on August 28, 2024

It looks like fn insert_learner and fn insert_voter both return a Result at this time. At a quick glance, the only way for them to panic would be for the assert_eq check in fn assert_progress_and_configuration_consistent to fail.

Did you want to add a ProgressConfigurationInconsistent error type and return that rather than panic? Or can this issue be marked as resolved for those two methods?

I'd be interested in taking a look at this issue, if you have any guidance on a particular panic! or unwrap which would be a good candidate for removal (assuming the two methods above should be marked as done).

from raft-rs.

Hoverbear avatar Hoverbear commented on August 28, 2024

Hi @JoshMcguigan You're right. I think this has been fixed, actually! :( Darnit!

from raft-rs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.