Comments (14)
🤦♀️ Ha, I'm sorry. :)
from raft-rs.
Maybe adding a comment is better.
/cc @Hoverbear
from raft-rs.
@bkchr Would adding a comment about this limit be satisfactory? Since NoLimit == Fixed(u64::MAX)
from raft-rs.
Yeah I know that NoLimit == Fixed(u64::MAX)
after looking into the code. I'm unsure. I think a comment would be a good start if you don't want to add an extra enum. However, adding an enum would be the cleaner solution in my point of view.
from raft-rs.
Perhaps Option<u64>
is appropriate. A None
value correctly communicates that The max size is none.
from raft-rs.
Yeah, an option would also fit here ;)
from raft-rs.
@bkchr Would you still be interested in making a PR, or is this open for others to tackle?
from raft-rs.
Open for others :)
from raft-rs.
Id like to work on this!
from raft-rs.
dang, too slow :/
from raft-rs.
sorry @estk, I should have commented when I started working on it :-/
if you are so inclined, I'd love some code review of my PR!
from raft-rs.
Sure thing @pwoolcoc, you're too quick on the draw :)
from raft-rs.
@estk Aw, thanks so much! Do you think you might be interested in this one instead? #70
from raft-rs.
@Hoverbear haha, you really gotta be quick here! Thanks for pointing that one out, but it looks like I'm too late again. I'll be away for the weekend but I'll swing back next week and try to pick up an issue. Thanks for the hospitality @Hoverbear
from raft-rs.
Related Issues (20)
- Unclear documentation for Progress maybe_snapshot_abort HOT 2
- [doc] minor typo in library documentation HOT 1
- Detach the delivery of Ready from the call to tick() to reduce commit latency. HOT 1
- How to watch the follower become leader? HOT 2
- How do I use the `ConfChangeType::AddLearnerNode` in `propose_conf_change`? HOT 4
- Panic in `become_leader` HOT 7
- Are there any plans to support [tracing](https://github.com/tokio-rs/tracing)? HOT 1
- File name too long during cargo build
- Make request_snapshot more safer
- Please release 0.7.0 on `crates.io` HOT 2
- Why is MsgSnapStatus considered a local message? HOT 3
- Question - Migrate `raft-rs 0.6.0a` to `raft-rs 0.7.0` HOT 1
- Is there some guidelines on calling step, ready and advance? HOT 3
- Initialization with term=0 shouldn't be allowed HOT 10
- Picked - Support asynchronous storage writes HOT 2
- Confusion about comments in raft.rs at line 1630 HOT 2
- What are vote leader and vote term? HOT 2
- Apple M1 support HOT 7
- Suggestion: Provides test suite for ensuring the storage implementation is correct HOT 1
- How to make the leader node implement log compressio? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from raft-rs.