Compilation error on Linux about rust-rocksdb

[Hoverbear]

Workaround:

CXXFLAGS="-Wno-deprecated-copy -Wno-pessimizing-move -Wno-sign-compare" cargo build

Seems when building TiKV with this you need:

CXXFLAGS='-Wno-error=deprecated-copy -Wno-error=pessimizing-move -Wno-error=sign-compare' cargo build

[yiwu-arbug]

Fix facebook/rocksdb#5651

[yiwu-arbug]

gcc has version 9 already?!

[BusyJay]

Surprise! /cc facebook/rocksdb#5303

[BusyJay]

Build with latest cherry pick still fails with following:

/home/jay/.cargo/git/checkouts/rust-rocksdb-82ef6e5337b3fbe6/6ead62c/librocksdb_sys/rocksdb/port/port_posix.cc: In function ‘int rocksdb::port::GetMaxOpenFiles()’:
/home/jay/.cargo/git/checkouts/rust-rocksdb-82ef6e5337b3fbe6/6ead62c/librocksdb_sys/rocksdb/port/port_posix.cc:180:31: error: comparison of integer expressions of different signedness: ‘rlim_t’ {aka ‘long unsigned int’} and ‘int’ [-Werror=sign-compare]
  180 |   if (no_files_limit.rlim_cur >= std::numeric_limits<int>::max()) {
      |       ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
gmake[4]: *** [CMakeFiles/rocksdb.dir/build.make:2991: CMakeFiles/rocksdb.dir/port/port_posix.cc.o] Error 1
gmake[4]: *** Waiting for unfinished jobs....
gmake[3]: *** [CMakeFiles/Makefile2:2714: CMakeFiles/rocksdb.dir/all] Error 2
gmake[2]: *** [CMakeFiles/Makefile2:2726: CMakeFiles/rocksdb.dir/rule] Error 2
gmake[1]: *** [Makefile:1036: rocksdb] Error 2
thread 'main' panicked at '
command did not execute successfully, got: exit code: 2

build script failed, must exit now', /home/jay/.cargo/registry/src/github.com-1ecc6299db9ec823/cmake-0.1.40/src/lib.rs:832:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

make: *** [Makefile:210: clippy] Error 101
env TMPDIR=/mnt/wwn-0x5002538d00000000-part1/workspace/temp/ make dev  1389.83s user 134.81s system 206% cpu 12:19.09 total

[yiwu-arbug]

@BusyJay not reproducing on my side (ubuntu 19.10 + gcc9). Does adding static_cast<int> around no_files_limit.rlim_cur work for you?

[BusyJay]

I can confirm that rust-rocksdb is built successfully using the latest compile toolchains on fedora 30.

[Hoverbear]

Related to #343