Comments (4)
I don't know how to fix this one, since OnFlushCompleted
don't know what's the input data size for each blob file.
from titan.
@yiwu-arbug
I think we can use output data size to get discardable_size of flushed blob file:
- If discardable_size == 0, then discardable_size = file_size - output_size
- if discardable_size > 0, then discardable_size = discardable_size - output_size ( for those blob file indexes that not be flushed completely in one run )
The problem is if all keys of a blob_file are deleted in memtable then we will still lose discardable_size.
from titan.
@wujy-cs sounds reasonable. So basically, a) mark the latest memtable id (say, M) after GC finish, b) wait till M flushed, then subtract file size by sum of output size of all memtables?
from titan.
@yiwu-arbug
Yes,. And we can do it in OnFlushCompleted without distinguishing gc rewritten blob file and flushed blob file, since outpu_size of flushed blob file always equals to file_size.
from titan.
Related Issues (20)
- blob file_level_ in blobfilemeta HOT 1
- GC in level_merge HOT 6
- db_bench core HOT 3
- io_read && io_write HOT 1
- parameter file_size is always 0 HOT 1
- Question about `TitanDBImpl::GetOldestSnapshotSequence()` HOT 2
- bug: key in compaction filter is internal key instead of userkey after apply IsStackedBlobDbInternalCompactionFilter HOT 9
- Any compact mechanism on titan's manifest file ? HOT 1
- Lazy load value in iterator HOT 1
- Blob file is left untouched in fallback mode HOT 3
- Store BlobStorage pointer in ColumnFamilyHandle
- Why titan forcibly set total_order_seek to true ? HOT 5
- File Size Not Really Used in GC HOT 1
- Leverage file system hole punching to avoid GC rewrite
- LRU cache misuse for BlobFileCache causes significant performance degradation HOT 3
- Whether titan can use the rocksdb original version or not HOT 1
- mirror the RocksDB's async IO optimization to titan in scan
- Wrong config when use DB::open without cf configs HOT 2
- BlobIndex will be broken and failed to decode when zero-terminated in blob handle in compaction filter HOT 2
- rate-limiter not limit the blobstorage read in compaction filter HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from titan.