DetectorAssert.addRegistrar(...) has no effect about test-driven-detectors4findbugs

[Grundlefleck]

Hi, sorry for delay in acknowledging your bug report. Taking a gander now.

[Grundlefleck]

Hi @GrimmiMeloni,

I don't believe there's any need to initialise FindBugs quite so aggressively. It should be possible to add and clear registrars, and also retrieve the testing BugReporter, without initialising FindBugs. Ideally this could be done with just an instance of DetectorAssert, which can be constructed and collected as needed, but there's so much static state within FindBugs that it would be very difficult to support this. I think just removed the eager initialisation in a few key places is the answer.

Making the change would be quite easy, but I would prefer to have an automated test. Would you be able to supply a minimal, not-working example? I'm not too familiar with custom analysis engines in FB, so it would really help me out. Gist or pull request, or pasting some text here, whatever is easiest for you.

[GrimmiMeloni]

Well, in theory I think a minimal EngineRegistrar that puts some noop-engine into the AnalysisContext could be sufficient already. A testcase would then just have to check if that engine is available (or if that's not directly possible check for some predetermiend result that's caused by that noop-engine).

I will try to find some time to have a look at the testcases again. Cannot promise anything at this point though (my desk is loaded).