Comments (5)
taylortrimble
commented on July 17, 2024
Gross. I expect this to get cleared up with #17 (synchronous Send, no requeueing?), but it's good to keep an eye on it.
from apns.
nathany
commented on July 17, 2024
I'd be happy just to remove the "set an identifier if not set" logic and always require it from the caller.
from apns.
nathany
commented on July 17, 2024
I still think removing determineIdentifier entirely would be the best bet. Just require the identifier from the client.
from apns.
taylortrimble
commented on July 17, 2024
I do like the idea of "transparent defaults", but I do see your point as well. I wouldn't be heartbroken either way. 😉
from apns.
nathany
commented on July 17, 2024
When replaying notifications, should it use the same IDs or call determineIdentifier for new ones?
from apns.
Related Issues (20)
- Hanging on send() HOT 4
- Handling timeouts/disconnects, dropping some pushes? HOT 14
- Revisit Error Types HOT 2
- Connection Ideas HOT 1
- Asynchronous send results in exiting before all notifications are sent HOT 10
- Related projects HOT 10
- Multiple notifications HOT 1
- Failednotifs HOT 3
- Graceful shutdown HOT 1
- New HTTP/2 Push Notification Provider API from Apple HOT 14
- sent 1000 push notes and it failed to send because of too many connections HOT 1
- Using the Feedback Service HOT 13
- TCP Keepalive option HOT 3
- What happens if key file is encrypted with a pass phares? HOT 4
- improve Notification.ToBinary() to reduce memory copy HOT 1
- Could not create feedback crypto/tls: failed to parse certificate PEM data HOT 3
- fatal error: all goroutines are asleep - deadlock! HOT 1
- How to Batch send push HOT 6
- Can not run google app engine HOT 1
- mutable-content key support not available
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apns.