Comments (8)
See #14.
Release notes for the project would would be nice, but since that isn't in place, git blame can be useful for seeing what changes are done and correlating those back to previous pull requests.
from apns.
Good tip!
OK, so it was to get around the fact that the Alert field is a value type. I still don't understand why the Alert's title and action aren't included in the zero check. That looks like a bug to me.
from apns.
You're right, it's probably a bug from working on this across a few separate pull requests.
#9 added Title and Action for Safari but apparently I didn't update isZero. 😦 🌴
from apns.
I've been looking through #9 and the others linked to from there, but I don't see the reason why Alert wasn't made a pointer. There's actually a post by you saying you'd changed it to a pointer. What was the reason ?
from apns.
That's a good question. Other than breaking the API, though we broke the API to make badge a pointer, so...
from apns.
Given that the loose coupling of the IsZero
command has immediately proven to be fraught with peril, I'd support making Alert
a pointer.
from apns.
Agreed. It's probably a better solution than introducing reflection or dealing with maintaining IsZero.
from apns.
Ditto. Closing in favor of #26 - with the addition of making Alert
a pointer.
Feel free to reopen if there is more to discuss.
from apns.
Related Issues (20)
- Hanging on send() HOT 4
- Handling timeouts/disconnects, dropping some pushes? HOT 14
- Revisit Error Types HOT 2
- Connection Ideas HOT 1
- Asynchronous send results in exiting before all notifications are sent HOT 10
- Related projects HOT 10
- Multiple notifications HOT 1
- Failednotifs HOT 3
- Graceful shutdown HOT 1
- New HTTP/2 Push Notification Provider API from Apple HOT 14
- sent 1000 push notes and it failed to send because of too many connections HOT 1
- Using the Feedback Service HOT 13
- TCP Keepalive option HOT 3
- What happens if key file is encrypted with a pass phares? HOT 4
- improve Notification.ToBinary() to reduce memory copy HOT 1
- Could not create feedback crypto/tls: failed to parse certificate PEM data HOT 3
- fatal error: all goroutines are asleep - deadlock! HOT 1
- How to Batch send push HOT 6
- Can not run google app engine HOT 1
- mutable-content key support not available
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from apns.