Comments (7)
Sorry @timolins but I don't think d60adb6 fixes the issue in RHT's users. Since it's "dev" dependency, it's not installed when the user installs RHT as their dependencies, so the warn would still be there
Maybe it's better to:
- Put csstype as devdependency in the user's package.json
- Put csstype as dependency of RHT
- Ask goober to put csstype as their dependency instead of peer
from react-hot-toast.
oh if that's the case it seems Yarn (or whatever package manager you are using) is more strict these days. Look like we will need to fix it properly (so either from RHT or from Goober)
from react-hot-toast.
Thanks for reporting. I guess we can add csstype as dependency, just like you mention. Since it's types only it shouldn't matter, other than giving you a better dev experience when styling.
from react-hot-toast.
@thien-do @timolins sorry to pull this issue out of the dark but we are trying to clean up our repo/packages and see the same resolution error with yarn:
react-hot-toast@npm:2.2.0 doesn't provide csstype, requested by goober
Is the suggestion that csstype must be installed as a dependency on our end, or is adding it as a devDependency good enough?
Also it may be worthwhile to add this to the ReadME if so.
Thanks!
from react-hot-toast.
Is the suggestion that csstype must be installed as a dependency on our end, or is adding it as a devDependency good enough?
Hard to say without knowing the codebase, but I think the best bet is you should not be asked to have a dependency if you don't use it directly. This means the best option should be:
Ask goober to put csstype as their dependency instead of peer
While the best workaround should be:
Put csstype as devdependency in the user's package.json
from react-hot-toast.
@thien-do ok i went ahead and added it as a dev dependency however I am still getting the same issue. The same resolution warning pops up. Any idea what to do here?
from react-hot-toast.
I'm running into this as well with latest yarn.
from react-hot-toast.
Related Issues (20)
- Custom / Position HOT 1
- Property 'document' doesn't exist || Cannot read property 'useToaster' of undefined. React Native HOT 2
- Toaster gives Unhandled RunTime Error on Nextjs HOT 4
- Toasts not firing (help). HOT 2
- How can i pass dynamic variable to toast.promise loading? HOT 1
- Allow customizing slide up/down animation
- Allow customizing exit animation when user manually dismisses toast HOT 2
- toast.loading() not working with nextjs 14 HOT 3
- Pause on Hover does not work with Headless UI HOT 1
- Dismiss toast by matching toastIds with regex
- Custom output direction HOT 1
- Support loading with "mask"
- Element type Error when using with nextjs and redux-toolkit
- Accessibility
- (Suggestion) Enhancing Web Accessibility
- Add delay to toast
- Feature Requests for warning and max toast
- Toast persists after page navigation HOT 1
- Support popover api
- Dismiss a headless toast? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-hot-toast.