Comments (4)
I guess minAspectRatio
-> minimumAspectRatio
from tocropviewcontroller.
Hey @inamiy! Long time no see! I hope you've been going well!
Hmm, interesting! So the idea is to have an "aspect ratio" range that the crop box can change shape inside?
Yeah, I feel like the delegate would be too late for that, but maybe it's not so hard to change the layoutSubviews
logic to change how the crop box is allowed to resize to support this.
Do you have some examples of some input/output images you would like to see from this sort of feature?
from tocropviewcontroller.
Yes, it's about restricting the crop box size to not become too long on one side!
I don't have a clear image yet on how the UX will be like.
It will be nicer if dev can customize error behavior when crop-box reaches to the error size,
e.g. show HUD, have haptic feedback and auto-resizing, etc.
I think auto-resizing is the easiest start, as well as providing its delegate method so that dev can additionally present custom HUD for warning message.
Crop-box size error detection timing is also another thing to consider.
I think errors on touchesEnded
is more preferred than touchesMoved
for now, as current impl also has auto-cropbox-resizing animation on touchesEnded
after delay, and single-shot per gesture is probably easier to manage.
from tocropviewcontroller.
One another idea is to have a crop-box frame to have a touchesMoved
so that users will be aware of invalid size but doesn't need to see custom error messages until touchesEnded
.
from tocropviewcontroller.
Related Issues (20)
- how to set dimming view
- Grid
- Make TOCropToolbar.backgroundView public, to enable manipulating background color. HOT 1
- how to change bottom toolbar's height?
- [BUG]pushing done button with dragging
- [Question] How to change cropping square size HOT 4
- Let the user move the image with mouse hold HOT 1
- Manually import folders doesnt work
- customAspectRatioName is missing in CropViewController
- Running on M1 Mac fails HOT 2
- Simply rotating image looses pixels each time
- Circular Croping not working on iPad HOT 1
- Xcode 14 built error HOT 13
- how to change color of title HOT 2
- Option (totally new functionality) to just set a rectangle inside image
- Crop view freezes on iOS until the background image is loaded completely.
- Support UIModalPresentationStyle.overFullScreen HOT 1
- ToCropViewController not working HOT 1
- Tuist support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from tocropviewcontroller.