GithubHelp home page GithubHelp logo

Comments (4)

sugitatestblue avatar sugitatestblue commented on September 22, 2024 1

I guess minAspectRatio -> minimumAspectRatio

from tocropviewcontroller.

TimOliver avatar TimOliver commented on September 22, 2024

Hey @inamiy! Long time no see! I hope you've been going well! 😁

Hmm, interesting! So the idea is to have an "aspect ratio" range that the crop box can change shape inside?

Yeah, I feel like the delegate would be too late for that, but maybe it's not so hard to change the layoutSubviews logic to change how the crop box is allowed to resize to support this.

Do you have some examples of some input/output images you would like to see from this sort of feature?

from tocropviewcontroller.

inamiy avatar inamiy commented on September 22, 2024

Yes, it's about restricting the crop box size to not become too long on one side!

I don't have a clear image yet on how the UX will be like.
It will be nicer if dev can customize error behavior when crop-box reaches to the error size,
e.g. show HUD, have haptic feedback and auto-resizing, etc.

I think auto-resizing is the easiest start, as well as providing its delegate method so that dev can additionally present custom HUD for warning message.

Crop-box size error detection timing is also another thing to consider.
I think errors on touchesEnded is more preferred than touchesMoved for now, as current impl also has auto-cropbox-resizing animation on touchesEnded after delay, and single-shot per gesture is probably easier to manage.

from tocropviewcontroller.

inamiy avatar inamiy commented on September 22, 2024

One another idea is to have a crop-box frame to have a 🟥 red color during touchesMoved so that users will be aware of invalid size but doesn't need to see custom error messages until touchesEnded.

from tocropviewcontroller.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.