Is it possible to add more dataset filters similar to Categories and Organizations about jkan

[timwis]

Hi @stevenvandervalk, glad to hear it! And I'm happy to help. Can you elaborate a bit on what you're trying to add? I think the issue you referenced talks about the ability to filter by multiple categories at the same time, but it sounds like you want to add additional filters (such as "license type" or something). Is that right?

EDIT: Nevermind - I wrote that before looking at your referenced commit! Taking a look now..

[timwis]

Looks like you've got it mostly working.

The only issue I can see is when you select a decade, it sets the others to 0, which isn't terrible but that doesn't seem to happen in the other filter lists.

If it's not populating for you, I think you're not running the npm commands (see the architecture page in the wiki.

[stevenvandervalk]

Thanks @timwis for the quick reply.

You were right, about both the original issue and I wasn't running the npm commands, not sure how I forgot about that!

I'll be creating a bunch of similar filters and documenting the process, is it of any help to jkan contribute such a page to the wiki? No worries if not.

Thanks again!

[timwis]

Sure @stevenvandervalk that would be great. Another thing to consider, since your decades-filter.js code is very similar to the organizations-filter.js code, is perhaps we should make a generic filter-panel.js component?

Regardless, adding a page to the wiki would be a valuable contribution, and worth doing first either way!

I'll close this for now, but feel free to re-open if you run into further issues.