Comments (4)
Do you have an example of what this looks like? Screenshots or a way to reproduce that effect are the easiest way to show me what's wrong.
from base16-emacs.
Here how it looks like when there is one possible completion:
Here the suggestion has background base03 and foreground base04.
from base16-emacs.
I believe the same thing would happen with secondary-selection and docstrings. So the one way to fix it - override foreground color in secondary-selection (and region?). But I don't know how appropriate it would be. It also can be fixed for company only. If it should be fixed at all, of course. It's specific for onedark theme. For default-dark it looks like:
from base16-emacs.
ok, I think I found a good solution. There is :distant-foreground
property that changes foreground only if the text is not readable. It is very convenient for selections because it changes background without touching foreground. After the fix it looks like:
from base16-emacs.
Related Issues (20)
- Weird black block when using global-display-line-numbers-mode HOT 1
- dired mode background color HOT 1
- Face definition by indirection — define base16 named colors, or faces to inherit from? HOT 5
- git changes on fringe HOT 2
- Tomorrow Theme Terminal Colors HOT 3
- ansi-term-color-vector improperly overridden HOT 2
- Warning (comp): base16-theme-pkg.el:7:1: Warning: the function ‘define-package’ is not known HOT 1
- font-lock-comment-delimiter-face = base02, which is for selection background
- Increase selection contrast on tomorrow day theme
- base16-emacs breaks on zoom when global-display-line-numbers-mode HOT 1
- Maintainers outside of base16-project HOT 1
- Add support for `tab-bar`
- Doom Emacs support
- Some colorschemes are missing when compared with base16-vscode HOT 3
- Update base16-theme-256-color-source to use symbols, not strings
- fix command spell mistake in README HOT 2
- Emacs doesn't update colors with updated theme until I restart Emacs HOT 3
- Org todo/done faces match some heading faces HOT 2
- Solaire mode support HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from base16-emacs.