TLSCertificateRequest question about scapy-ssl_tls

[tintinweb]

Hi @hsl123,

Fixed the attrib error in ssl_tls.py#L930 length_of="dns" should read length_of="ca_dns".

It's in master already. Please give it a try and report back.

cheers,
tin

class TLSCertificateRequest(Packet):
    name = "TLS Certificate Request"
    fields_desc = [XFieldLenField("type_length", None, length_of="types", fmt="B"),
                   PacketListField("types", TLSCertificateType(), TLSCertificateType, length_from=lambda x: x.type_length),
                   XFieldLenField("alg_length", None, length_of="algs", fmt="H"),
                   ReprFieldListField("algs", DEFAULT_SIG_SCHEME_LIST, ShortEnumField("alg", None, TLS_SIGNATURE_SCHEMES),
                                      length_from=lambda x: x.alg_length),
                   XFieldLenField("dn_length", None, length_of="dns", fmt="H"),
                   PacketListField("ca_dns", None, TLSCADistinguishedName, length_from=lambda x: x.dn_length)]

example (did not fully test it):

>>> (TLSRecord()/TLSHandshakes(handshakes=[TLSHandshake()/TLSCertificateRequest(ca_dns=TLSCADistinguishedName(ca_dn="hi"))])).show()
###[ TLS Record ]###
  content_type= handshake
  version   = TLS_1_0
  length    = None
###[ TLS Handshakes ]###
     \handshakes\
      |###[ TLS Handshake ]###
      |  type      = certificate_request
      |  length    = None
      |###[ TLS Certificate Request ]###
      |     type_length= None
      |     \types     \
      |      |###[ TLS Certificate Type ]###
      |      |  type      = rsa_sign
      |     alg_length= None
      |     algs      = ['ecdsa_secp521r1_sha512', 'ecdsa_secp384r1_sha384', 'ecdsa_secp256r1_sha256', 'rsa_pkcs1_sha512', 'rsa_pkcs1_sha384', 'rsa_pkcs1_sha256', 'rsa_pkcs1_sha1']
      |     dn_length = None
      |     \ca_dns    \
      |      |###[ TLS CA Distinguished Name ]###
      |      |  length    = None
      |      |  ca_dn     = 'hi'

[hsl123]

It works. Thanks. From: tintin <[email protected]<mailto:[email protected]>> Reply-To: tintinweb/scapy-ssl_tls <[email protected]<mailto:[email protected]>> Date: Friday, October 6, 2017 at 12:35 PM To: tintinweb/scapy-ssl_tls <[email protected]<mailto:[email protected]>> Cc: Songling Han <[email protected]<mailto:[email protected]>>, Mention <[email protected]<mailto:[email protected]>> Subject: Re: [tintinweb/scapy-ssl_tls] TLSCertificateRequest question (#106) Hi @hsl123<https://github.com/hsl123>, Fixed the attrib error in ssl_tls.py#L930<https://github.com/tintinweb/scapy-ssl_tls/blob/master/scapy_ssl_tls/ssl_tls.py#L930> length_of="dns" should read length_of="ca_dns". It's in master already. Please give it a try and report back. cheers, tin class TLSCertificateRequest(Packet): name = "TLS Certificate Request" fields_desc = [XFieldLenField("type_length", None, length_of="types", fmt="B"), PacketListField("types", TLSCertificateType(), TLSCertificateType, length_from=lambda x: x.type_length), XFieldLenField("alg_length", None, length_of="algs", fmt="H"), ReprFieldListField("algs", DEFAULT_SIG_SCHEME_LIST, ShortEnumField("alg", None, TLS_SIGNATURE_SCHEMES), length_from=lambda x: x.alg_length), XFieldLenField("dn_length", None, length_of="dns", fmt="H"), PacketListField("ca_dns", None, TLSCADistinguishedName, length_from=lambda x: x.dn_length)] example (did not fully test it):

>> (TLSRecord()/TLSHandshakes(handshakes=[TLSHandshake()/TLSCertificateRequest(ca_dns=TLSCADistinguishedName(ca_dn="hi"))])).show()

###[ TLS Record ]### content_type= handshake version = TLS_1_0 length = None###[ TLS Handshakes ]### \handshakes\ |###[ TLS Handshake ]### | type = certificate_request | length = None |###[ TLS Certificate Request ]### | type_length= None | \types \ | |###[ TLS Certificate Type ]### | | type = rsa_sign | alg_length= None | algs = ['ecdsa_secp521r1_sha512', 'ecdsa_secp384r1_sha384', 'ecdsa_secp256r1_sha256', 'rsa_pkcs1_sha512', 'rsa_pkcs1_sha384', 'rsa_pkcs1_sha256', 'rsa_pkcs1_sha1'] | dn_length = None | \ca_dns \ | |###[ TLS CA Distinguished Name ]### | | length = None | | ca_dn = 'hi' - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#106 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ASmFlo6MwJ9WYNSqkWJIau8XGXDnleQSks5spoEXgaJpZM4Pw1D0>.