TLSRecord length calculation is incorrect about scapy-ssl_tls

[alexmgr]

Fixed in commit 27b3d1e of pull request #13

[tintinweb]

see comment in #13

the basic idea is to change

stacked_pkt = tls.TLSRecord()/tls.TLSHandshake()/tls.TLSServerHello()/tls.TLSRecord()/tls.TLSHandshake()/tls.TLSCertificateList()/tls.TLSRecord()/tls.TLSHandshake()/tls.TLSServerHelloDone()
pkt = tls.TLS(str(stacked_pkt))

to

stacked_pkt = SSL()
stacked_pkt.records = [(tls.TLSRecord()/tls.TLSHandshake()/tls.TLSServerHello()), tls.TLSRecord()/tls.TLSHandshake()/tls.TLSCertificateList(), tls.TLSRecord()/tls.TLSHandshake()/tls.TLSServerHelloDone() ]

[alexmgr]

I think people using this would expect this version to work

stacked_pkt = tls.TLSRecord()/tls.TLSHandshake()/tls.TLSServerHello()/tls.TLSRecord()/tls.TLSHandshake()/tls.TLSCertificateList()/tls.TLSRecord()/tls.TLSHandshake()/tls.TLSServerHelloDone()
pkt = tls.TLS(str(stacked_pkt))

because it follows the same flow as other packets.
I agree the solution you propose is simpler, but it forces people to read the documentation which is pretty optimistic ;)

[tintinweb]

The way to go is #16. #17 is DUP to #16 therefore we'll just close it. Sample output in #17 should also apply to #16. #16 therefore should fix dissecting of stacked records.
As discussed in #13 support for stacked records will be implemented as SSL.from_records([TLSRecord/..., TLSRecord/...]) otherwise we'd add non obvious side-effects.

any objections about closing this issue?

[alexmgr]

No objection ;), All set.