Aysnc methods on resource clients do not use standard Async naming conventions about dotnet-kube-client

[tintoy]

Hi - thanks for the feedback!

I’ll try to have a proper look at this sometime on Thursday.

[tintoy]

Hey, thanks for taking the time to leave such detailed feedback - sorry for the late response, but work has been a little crazy recently.

I guess I'd never really noticed that particular problem because I've never run into it; I haven't tried using var in that way, but I can see how the issue could be tricky to spot in that scenario. I'm sorry the API design caught you out like that; I usually try to think carefully about API-design footguns and avoid them where practical. I previously considered changing the naming of async methods but it would represent a breaking change to existing users and I try hard to avoid that if it all possible.

If it helps, the code you specified in your example should generate compiler warning CS4014; I appreciate that it's not ideal, but it's better than nothing 🙂

Glad to hear you find it useful, BTW!

[SiliconKid]

Hi Adam

I think the ideal scenario here is to provide async method signatures with the standard Async suffix but leave the existing methods without the suffix so as not to cause breaking changes. Just make the Async methods call the ones without the suffix so there's no code duplication.

That way people will at least see the method signatures with the Async convention in intellisense and can use those, but under the hood both variants of the method are actually async and will work.

Allan