Hey, not sure if you're excepting pull requests on this but i'm using your solution (pretty much exactly what I was looking for so firstly thankyou for saving me the time) but found a bug and a tweak i'd like to make.
Bug: when you have a key with 0 value, if there is a default set for that key, this will incorrectly get overwritten with the default. In my branch (not submitted yet) i've tweaked that and the test cases to check for it.
Tweak: I want to be able to pass no 'defaults' argument and have it delete keys where there's no value as 'undefined' is not valid JSON.
Let me know if you are interested and i'll push my code up.
Cheers,
Kevin
Hey Tyler,
I've just submitted a pull request for the fix I mentioned. I'll do a separate request later for my suggested updates so you can evaluate those separately.
Cheers,
Kevin
Date: Sat, 14 Jun 2014 05:32:46 -0700
From: [email protected]
To: [email protected]
CC: [email protected]
Subject: Re: [node-remapped] 0 value bug (#2)
I am most definitely accepting contributions. I'd love to check out your PR, please submit away!
—
Reply to this email directly or view it on GitHub.