GithubHelp home page GithubHelp logo

a bug in ismember function? about gae HOT 2 CLOSED

certaincen avatar certaincen commented on May 26, 2024
a bug in ismember function?

from gae.

Comments (2)

tkipf avatar tkipf commented on May 26, 2024

Thanks for catching this! This is indeed a bug and I have no idea what happened here (obviously a bug like this shouldn't happen with proper coding / unit testing practices).

The ismember function should look like this instead:

def ismember(a, b, tol=5):
    rows_close = np.all(np.round(a - b[:, None], tol) == 0, axis=-1)
    return np.any(rows_close)

I re-ran the Cora link prediction experiments with it and it looks like results are quite similar (I got slightly better results now than reported in the paper, but this could just be an outlier). I'll investigate this further. Feel free to make a pull request if you'd like to be listed as a contributor- otherwise I'll push the changes myself.

from gae.

tkipf avatar tkipf commented on May 26, 2024

Fixed with cc5aa6c

from gae.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.