GithubHelp home page GithubHelp logo

Comments (10)

rubenvereecken avatar rubenvereecken commented on May 11, 2024 3

I didn't realise this was the linter, amazing that that's still going.

Alright then, I'm happy to give someone else access. @owenvoke since I see you're a tldr organization member I'm adding you.

from tldr-lint.

sbrl avatar sbrl commented on May 11, 2024 3

Can do, @owenvoke! The more org owners we have there the better I think.

Sorry, it's University induction this week and last week, so I've been a bit busy lol. Should be getting back to normal next week.

from tldr-lint.

owenvoke avatar owenvoke commented on May 11, 2024 2

Closing this as we've pushed a new version a few months ago, and will be pushing a new version again soon. 👍🏻

from tldr-lint.

owenvoke avatar owenvoke commented on May 11, 2024 1

Been thinking about this, I was going to add GitHub Actions for testing this repo. Do you think it's also worth adding publishing when tags are pushed? 🤔 https://github.com/actions/setup-node

from tldr-lint.

rubenvereecken avatar rubenvereecken commented on May 11, 2024 1

Ooh is that so? I haven't been involved in active development for - at a guess - over three years. I'm sorry, I haven't pushed anything to npm since and don't think I'll be of any use.

from tldr-lint.

owenvoke avatar owenvoke commented on May 11, 2024 1

Added you @sbrl, and @agnivade as maintainers. 👍🏻

from tldr-lint.

navarroaxel avatar navarroaxel commented on May 11, 2024

Updating dependencies of this package?
Are we using semver in this project?

The dependencies are really old, IMO that kind of upgrade has the honor of bump a major version. I can take a look to that but not for this easy regex fix.

IMO a dependency shouldn't have a package-lock.json because of this:

Committing package-lock.json to the source code version control means that the project maintainers and CI systems will use a specific version of dependencies that may or may not match those defined in package.json. Because package-lock.json cannot be added to NPM registry (by design; see NPM shrinkwrap), projects that depend on a project that uses package-lock.json will themselves use package.json to resolve project's dependencies, i.e. what works for project maintainers/ CI systems might not work when the project is used as a dependency.

The origin of this misuse is NPM documentation. It should instead explain that package-lock.json should only be committed to the source code version control when the project is not a dependency of other projects, i.e. package-lock.json should only by committed to source code version control for top-level projects (programs consumed by the end user, not other programs).

We should add a .npmrc file with:

package-lock=false

from tldr-lint.

owenvoke avatar owenvoke commented on May 11, 2024

@rubenvereecken, I'm not sure, but I think as you were the last one to release it, you may need to grant another maintainer access. 🤔

Should be listed here: https://www.npmjs.com/package/tldr-lint/access

from tldr-lint.

owenvoke avatar owenvoke commented on May 11, 2024

It might be worth adding @sbrl as well. 👍🏻 Cheers @rubenvereecken.

from tldr-lint.

owenvoke avatar owenvoke commented on May 11, 2024

@sbrl, do you want me to add you as a maintainer for the npm package so you can push the new version? 🤔

from tldr-lint.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.